Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

SPF5122Z RF ampllifier #2870

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SPF5122Z RF ampllifier #2870

wants to merge 2 commits into from

Conversation

chmorgan
Copy link
Collaborator

@chmorgan chmorgan commented Jul 19, 2020

image

Datasheet: https://www.qorvo.com/products/d/da001904

Footprint pull request: KiCad/kicad-footprints#2368


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 21, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Jul 21, 2020
@myfreescalewebpage myfreescalewebpage added Pending footprint Pending footprint acceptance before merging and removed Pending reviewer A pull request waiting for a reviewer labels Jul 21, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jul 21, 2020

Hi @chmorgan , thanks for contributing,

A few comments I have during my review:

  • Description should ends with package name ", DFN-8"
  • keywords in lower case only is great
  • Footprint filter should be DFN*1EP*2x2mm*P0.5mm*
  • Pin 3 and 6 should be stacked with GND

Cheers,
Joel

@chmorgan
Copy link
Collaborator Author

Hi @myfreescalewebpage. Thanks for yet another review!

I fixed the footprint filter, keywords case and added the package to the description. As this is a high frequency RF part I've been assuming that the mfg footprint recommendations were the best way to achieve performance. Even though 3 and 6 are NC pins the mfg recommends tying them together with the adjacent pins as I've done.

See the two below images cut from the datasheet:

image

image

@myfreescalewebpage
Copy link
Collaborator

Hi @chmorgan with pleasure :)
Thanks for pointing this details, accepted.
Just need to wait the footprint.
Joel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants