Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus support (Fixes #3407) #3453

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Oct 10, 2024

Fixes #3407

  • Basic setup
  • Unit tests
  • Test with resource manipulation tests with prometheus enabled
  • Documentation

@leplatrem leplatrem force-pushed the 3407-add-prometheus-support branch from 35b505b to 97c8975 Compare October 10, 2024 15:22
@leplatrem leplatrem force-pushed the 3407-add-prometheus-support branch from 97c8975 to 80f2244 Compare October 11, 2024 11:13
@leplatrem leplatrem marked this pull request as ready for review October 14, 2024 09:58
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one nit

@leplatrem leplatrem merged commit 797fb75 into main Oct 16, 2024
19 checks passed
@leplatrem leplatrem deleted the 3407-add-prometheus-support branch October 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Promotheus support
2 participants