-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove testFail
from tests and prefer vm.expectRevert
#23
Conversation
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use
solc-versionImpact: Informational
|
3990755
to
66b1e48
Compare
ebec3f5
to
62f506a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 67.31% 73.72% +6.41%
==========================================
Files 10 10
Lines 413 411 -2
Branches 114 113 -1
==========================================
+ Hits 278 303 +25
+ Misses 51 48 -3
+ Partials 84 60 -24
|
bd6239c
to
0340b48
Compare
0340b48
to
50904e5
Compare
Bubble up errors from `UserOperationRevertReason`
testFail*
tests to useexpectRevert()
orexpectEmit()
in the case of the tests that expect theUserOperationRevertReason
event to be emitted.