Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure owner is assigned correctly when created by an EOA #24

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

rrecuero
Copy link
Contributor

@rrecuero rrecuero commented Jan 3, 2024

No description provided.

@rrecuero rrecuero requested a review from fedealconada January 3, 2024 22:30
Copy link

github-actions bot commented Jan 3, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

solc-version

Impact: Informational
Confidence: High

  • ID-0
    solc-0.8.17 is not recommended for deployment

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3049c2b) 67.23% compared to head (9a9bf22) 67.23%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   67.23%   67.23%           
=======================================
  Files          10       10           
  Lines         412      412           
  Branches      114      114           
=======================================
  Hits          277      277           
  Misses         51       51           
  Partials       84       84           
Files Coverage Δ
src/wallet/KintoWalletFactory.sol 64.58% <50.00%> (ø)

Copy link
Contributor

@fedealconada fedealconada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fedealconada
Copy link
Contributor

btw, i fixed Slither :)

@rrecuero rrecuero merged commit 2db164e into main Jan 4, 2024
7 of 8 checks passed
@rrecuero rrecuero deleted the small-fixes branch January 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants