Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove recoverer funding limitation #288

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

VSBDev
Copy link
Contributor

@VSBDev VSBDev commented Oct 3, 2024

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@VSBDev VSBDev requested a review from rrecuero October 3, 2024 14:09
Copy link

openzeppelin-code bot commented Oct 3, 2024

chore: remove recoverer funding limitation

Generated at commit: 53a048323f79c4b069b6363d51214b80d2f4bf1c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
1
0
12
39
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@ylv-io
Copy link
Collaborator

ylv-io commented Oct 5, 2024

Look, we actually have tests. Nice.

Copy link

github-actions bot commented Oct 9, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (864d822) to head (53a0483).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   89.53%   89.52%   -0.01%     
==========================================
  Files          35       35              
  Lines        1758     1757       -1     
==========================================
- Hits         1574     1573       -1     
  Misses        184      184              
Files with missing lines Coverage Δ
src/wallet/KintoWalletFactory.sol 98.76% <ø> (-0.02%) ⬇️

@ylv-io ylv-io merged commit 9089d2e into main Oct 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants