Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Nio Governance #297

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Deploy Nio Governance #297

merged 8 commits into from
Oct 25, 2024

Conversation

ylv-io
Copy link
Collaborator

@ylv-io ylv-io commented Oct 24, 2024

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

…tion initialization to accept owner address.
…t salt calculation for NioGovernor deployment.
…json with new contract addresses for AccessManager, NioElection, NioGovernor, and NioGuardians.
Copy link

openzeppelin-code bot commented Oct 24, 2024

Deploy Nio Governance

Generated at commit: a975fcf56f676e6302ab8e5d56517a8b3bdc97eb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
1
0
12
39
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

github-actions bot commented Oct 24, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (247bd51) to head (a975fcf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/governance/NioElection.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files          38       38           
  Lines        2009     2009           
=======================================
  Hits         1805     1805           
  Misses        204      204           
Files with missing lines Coverage Δ
src/paymasters/SponsorPaymaster.sol 94.89% <ø> (ø)
src/governance/NioElection.sol 98.76% <0.00%> (ø)

@ylv-io ylv-io merged commit 450ae42 into main Oct 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant