Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppRegistry add remove contracts #310

Merged
merged 7 commits into from
Nov 9, 2024

Conversation

ylv-io
Copy link
Collaborator

@ylv-io ylv-io commented Nov 8, 2024

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Copy link

openzeppelin-code bot commented Nov 8, 2024

AppRegistry add remove contracts

Generated at commit: c56434bcf1e53c99f363e225cdc31c94830aacca

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
1
0
12
39
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@ylv-io ylv-io changed the title App registry add remove contracts AppRegistry add remove contracts Nov 8, 2024
…unction and update error handling in KintoAppRegistry and tests.
…pdate access modifiers, and remove redundant assertions.
Copy link

github-actions bot commented Nov 9, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (0eb6f07) to head (c56434b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/apps/KintoAppRegistry.sol 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   90.21%   90.30%   +0.08%     
==========================================
  Files          37       37              
  Lines        1932     1960      +28     
==========================================
+ Hits         1743     1770      +27     
- Misses        189      190       +1     
Files with missing lines Coverage Δ
src/apps/KintoAppRegistry.sol 91.25% <97.36%> (+0.93%) ⬆️

…orization, removing redundant _checkOwner calls.
…d addresses, and modify related test artifacts for chain 7887.
@ylv-io ylv-io merged commit 850d688 into main Nov 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants