-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppRegistry add remove contracts #310
Conversation
…interface with new errors and events.
…including edge cases for ownership and contract registration.
… in IKintoAppRegistry interface.
AppRegistry add remove contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…unction and update error handling in KintoAppRegistry and tests.
…pdate access modifiers, and remove redundant assertions.
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 90.21% 90.30% +0.08%
==========================================
Files 37 37
Lines 1932 1960 +28
==========================================
+ Hits 1743 1770 +27
- Misses 189 190 +1
|
…orization, removing redundant _checkOwner calls.
…d addresses, and modify related test artifacts for chain 7887.
Description
Type of change
Checklist:
main
, or there's a description of how to mergeIssue Resolution