Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aave repay workflow fix #315

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Aave repay workflow fix #315

merged 5 commits into from
Nov 18, 2024

Conversation

ylv-io
Copy link
Collaborator

@ylv-io ylv-io commented Nov 18, 2024

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

… tests accordingly, and changing testGetAccountData_BeforeLending to a view function.
Copy link

openzeppelin-code bot commented Nov 18, 2024

Aave repay workflow fix

Generated at commit: 25e4d6540adb424990622e2b27f4135bb7016b5a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

…kflow with AaveBorrowWorkflow and AaveRepayWorkflow, update contract addresses and transaction details across multiple chains, and remove redundant workflow checks in migration script.
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (56f88cd) to head (25e4d65).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   90.55%   90.57%   +0.02%     
==========================================
  Files          41       41              
  Lines        2011     2016       +5     
==========================================
+ Hits         1821     1826       +5     
  Misses        190      190              
Files with missing lines Coverage Δ
src/access/workflows/AaveBorrowWorkflow.sol 100.00% <100.00%> (ø)
src/access/workflows/AaveRepayWorkflow.sol 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

…ct addresses, and modified the deployment script to include new workflows and ensure proper workflow registration.
@ylv-io ylv-io merged commit 1967af3 into main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant