Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Viewer get access point address #317

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

ylv-io
Copy link
Collaborator

@ylv-io ylv-io commented Nov 20, 2024

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

…entation addresses, and modify Viewer contract to use `getAddress` instead of `getAccessPoint`.
Copy link

Fix Viewer get access point address

Generated at commit: 191a2fb5f09c2f2db9155d126f6e8de12b282e65

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (6b9fc53) to head (191a2fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          41       41           
  Lines        2016     2016           
=======================================
  Hits         1826     1826           
  Misses        190      190           
Files with missing lines Coverage Δ
src/viewers/Viewer.sol 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@ylv-io ylv-io merged commit 8f2ea4e into main Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant