KYC Sanction Expiration

[ylv-io]

Description

This pull request introduces several enhancements and modifications to the KintoID contract, focusing on governance, sanction management, and role definitions. It also updates the IKintoID interface to reflect these changes.

Implementation Details:

• Added a new constant GOVERNANCE_ROLE to define a governance role within the contract.
• Introduced two new immutable addresses: walletFactory and faucet, which are now public and override existing definitions.
• Deprecated the walletFactory address by making it private and adding a notice for its deprecation.
• Added a new mapping sanctionedAt to track the timestamp of the last sanction applied to each user.
• Updated the revokeKYC function to set the sanctionedAt timestamp to the current block timestamp when a KYC is revoked.
• Modified the addSanction function to update the sanctionedAt timestamp when a sanction is added.
• Enhanced the isKYC function to include logic for checking if an account is sanctions safe and handling the 3-day confirmation period for sanctions.
• Updated the isSanctionsSafe function to incorporate the 3-day confirmation logic for sanctions and to check if an account is monitored for sanctions.
• Introduced a new function confirmSanction that allows the governance role to reset the sanction timestamp, making the sanction indefinite.
• Corrected a typo in the isIndividual function's return description from "indivdual" to "individual".
• Updated the IKintoID interface to include the new GOVERNANCE_ROLE function.

Type of change

• Bug fix
• New feature
• Breaking change
• Dependency changes
• Deployment
• Forge Script
• Code refactor / cleanup
• Documentation or wording changes
• Other

Checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented, including external interfaces
• Tests have 100% code coverage
• The base branch is either main, or there's a description of how to merge

Issue Resolution

[openzeppelin-code]

KYC Sanction Expiration

Generated at commit: 7e2f2d1003f6f8fc77587bc31c99ded200a042f6

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	4 2 0 12 39 57
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[rrecuero]

I believe we should just return false in this case, if there is no NFT it should be false

[github-actions]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (ae284ac) to head (7a226c7).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   90.57%   89.04%   -1.53%     
==========================================
  Files          41       41              
  Lines        2016     2483     +467     
==========================================
+ Hits         1826     2211     +385     
- Misses        190      272      +82     

Files with missing lines	Coverage Δ
src/KintoID.sol	98.77% <100.00%> (-0.43%)	⬇️

... and 40 files with indirect coverage changes