Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask #130

Open
13 tasks
kashike opened this issue Aug 9, 2016 · 3 comments
Open
13 tasks

Mask #130

kashike opened this issue Aug 9, 2016 · 3 comments

Comments

@kashike
Copy link
Member

kashike commented Aug 9, 2016

  • fromString
  • of(String, String, String)
    • nick, ident, hostname
  • Optional<String> getNick()
  • Optional<String> getIdent()
  • Optional<String> getHostname()
  • test(User) (Predicate<User>)
    • determine if a User matches this Mask
  • Collection<User> getMatches(Channel)
    • get a Collection of Users in the specified Channel which match this Mask
@kashike
Copy link
Member Author

kashike commented Aug 9, 2016

02:31:12     @mbaxter | Maybe more static methods for like, just matching hostname
02:31:35     @mbaxter | or account ($a:account) and other extbans things

@Zarthus
Copy link
Member

Zarthus commented Aug 9, 2016

(19:38:02) <+Zarthus> Sort of a cross comment between #130 and #122, 
(19:38:02) <+Zarthus> But not every ban is a mask. Example: $a:account
(19:38:48) <@mbaxter> It's kinda like a mask! :3
(19:39:11) <+Zarthus> I think you're currently converting every ban into a mask, but #130 seems to mostly go in to the direction of "each ban has at least ! and @" 

@mbax mbax modified the milestone: 2.4.0 Aug 24, 2016
@mbax mbax modified the milestones: 3.0.0, 3.1.0 Dec 29, 2016
@mbax mbax modified the milestones: 3.1.0, Future! Feb 9, 2017
@mbax mbax removed the baxtoberfest label Dec 31, 2017
@mbax
Copy link
Member

mbax commented Feb 19, 2019

Closing the following PRs, with the hope of using them later under a separate PR:

#136
#207

The PR would come from this branch: https://github.com/KittehOrg/KittehIRCClientLib/commits/maskTakeThree

@mbax mbax mentioned this issue Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants