API for bans, abstracted to support quiets/exempt #122

mbax · 2016-07-06T01:52:27Z

Done:

Create Ban element
Create a list of Bans when MODE #channel +b gets a reply

TODO:

Track bans for channels the client is in
Convenience method for removing a ban
Event for ban list being updated (e.g. shortly after channel join)
Maybe toggle tracking of bans per channel.

Zarthus · 2016-07-06T07:50:33Z

If you're going to do

Maybe toggle tracking of bans per channel

You might as well make it configurable:

Char[] modesToTrack = { 'b', 'q', 'I', 'e' }
                                // ^    ^ only gettable by ops i think
                                // may be configurable on some ircds

Also just a global toggle would be nice.

Zarthus · 2016-07-06T07:51:09Z

src/main/java/org/kitteh/irc/client/library/element/mode/Ban.java

+    String getId();
+
+    @Nonnull
+    Optional<Integer> getTimeLeft();


It's not the time left, but the date the ban was set (as best known as by the IRCd. Which might not be very reliable to begin with)

This could be an Instant (going off what @Zarthus noted above).

Or Duration if @Zarthus was wrong (you never know 😇)

It's an unix timestamp, for the curious.

codecov-io · 2016-07-08T01:18:15Z

Current coverage is 34.15% (diff: 1.75%)

Merging #122 into next will decrease coverage by 1.04%

@@               next       #122   diff @@
==========================================
  Files           135        138     +3   
  Lines          3301       3408   +107   
  Methods           0          0          
  Messages          0          0          
  Branches        469        490    +21   
==========================================
+ Hits           1162       1164     +2   
- Misses         2109       2214   +105   
  Partials         30         30

Powered by Codecov. Last update 46cdf11...4060da5

kashike · 2016-07-08T10:06:57Z

src/main/java/org/kitteh/irc/client/library/event/channel/ChannelModeInfoListEvent.java

+/**
+ * A list of mode info is available!
+ */
+public class ChannelModeInfoListEvent extends ChannelEventBase {


I assume this is for bans, quiets, etc.
There's currently no way, that I can see, to determine which type of list this is.

From latest commit - "Needs way of knowing it's a ban"

kashike · 2016-08-09T01:56:14Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+                this.modeInfoLists.get(modeInfo.getMode().getChar()).add(modeInfo);
+            } else {
+                Iterator<ModeInfo> iterator = this.modeInfoLists.get(modeInfo.getMode().getChar()).iterator();
+                while (iterator.hasNext()){


Zarthus · 2016-08-09T16:21:09Z

src/main/java/org/kitteh/irc/client/library/util/Mask.java

+/**
+ * Represents a mask that can match a {@link User}.
+ */
+public class Mask {


boolean existsIn(List<ModeInfo>) utility? (or for User)

Also maybe a comparator?

Zarthus · 2016-08-09T16:23:11Z

Sidecomments:

Some IRCds support /mode #channel bqIe, does KICL support that? (I have no idea where this feature is documented, or how to detect it) -- sounds like a neat optimization.

Does KICL currently handle "you're sending too many commands and are being ratelimited", how does it play in on this?

mbax · 2016-08-09T17:30:12Z

KICL does not currently handle rate limiting. As for querying modes that way, no it doesn't either.

Zarthus reviewed Jul 6, 2016
View reviewed changes

mbax added enhancement proposal labels Jul 8, 2016

kashike reviewed Jul 8, 2016
View reviewed changes

mbax added this to the 2.1.0 milestone Jul 9, 2016

mbax force-pushed the next branch from f0f3854 to ed769f1 Compare July 10, 2016 18:39

mbax modified the milestones: 2.1.0, 2.2.0 Jul 11, 2016

mbax force-pushed the next branch from 2d30418 to b2ec48e Compare July 22, 2016 22:21

mbax force-pushed the bans branch from 4fc6437 to b45b47f Compare July 22, 2016 22:25

mbax changed the title ~~API for bans~~ API for bans, quiets, and more Jul 22, 2016

mbax changed the title ~~API for bans, quiets, and more~~ API for bans, abstracted to support quiets/exempt Aug 3, 2016

mbax force-pushed the next branch from bd15d97 to 46cdf11 Compare August 9, 2016 01:45

mbax force-pushed the bans branch from b9803b5 to 2b3130c Compare August 9, 2016 01:52

kashike reviewed Aug 9, 2016
View reviewed changes

mbax force-pushed the bans branch from 2b3130c to eada163 Compare August 9, 2016 01:59

Ban information and tracking

4060da5

mbax force-pushed the bans branch from eada163 to 4060da5 Compare August 9, 2016 02:16

mbax merged commit 4060da5 into next Aug 9, 2016

Zarthus reviewed Aug 9, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API for bans, abstracted to support quiets/exempt #122

API for bans, abstracted to support quiets/exempt #122

mbax commented Jul 6, 2016 •

edited

Loading

Zarthus commented Jul 6, 2016 •

edited

Loading

Zarthus Jul 6, 2016

kashike Jul 6, 2016

bendem Jul 6, 2016

Zarthus Jul 6, 2016

codecov-io commented Jul 8, 2016 •

edited

Loading

kashike Jul 8, 2016

mbax Jul 8, 2016

kashike Aug 9, 2016

Zarthus Aug 9, 2016 •

edited

Loading

Zarthus Aug 9, 2016

mbax Aug 9, 2016

Zarthus commented Aug 9, 2016 •

edited

Loading

mbax commented Aug 9, 2016

API for bans, abstracted to support quiets/exempt #122

API for bans, abstracted to support quiets/exempt #122

Conversation

mbax commented Jul 6, 2016 • edited Loading

Zarthus commented Jul 6, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jul 8, 2016 • edited Loading

Current coverage is 34.15% (diff: 1.75%)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zarthus Aug 9, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zarthus commented Aug 9, 2016 • edited Loading

mbax commented Aug 9, 2016

mbax commented Jul 6, 2016 •

edited

Loading

Zarthus commented Jul 6, 2016 •

edited

Loading

codecov-io commented Jul 8, 2016 •

edited

Loading

Zarthus Aug 9, 2016 •

edited

Loading

Zarthus commented Aug 9, 2016 •

edited

Loading