Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BlueRSA, BlueECC and BlueCrypto with Apple's Swift Crypto #118

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Replace BlueRSA, BlueECC and BlueCrypto with Apple's Swift Crypto #118

wants to merge 6 commits into from

Conversation

wassup-
Copy link

@wassup- wassup- commented Aug 4, 2023

Since I was running into the same issue as #117 , I decided to actually switch over to Apple's Swift Crypto.
For me this fixes the build issues. Make sure to leave a comment if it doesn't for you!

The most notable changes:

  • minimum deployment targets: iOS 14.0, macOS 11.0
  • currently supports only ECDSA and HMAC, support for RSA is missing!
  • formatted code using SwiftFormat (this is a separate commit)

RSA support is missing because -if I'm not mistaken- RSA is not currently part of Swift Crypto.
Any suggestions on how to add support RSA are welcome!

@wassup-
replace BlueRSA, BlueECC and BlueCryptor with Apple's Swift Crypto
a1b86f1 
this currently drops support for RSA
@wassup-
add and run SwiftFormat
3070404 
run using `swift package plugin --allow-writing-to-package-directory swiftformat`
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wassup-
re-enable some tests
7d42954 
- add testSignAndVerifyECDSA256
- rewrite testJWTEncoder, testJWTDecoder and testJWTCoderCycle to use ECDSA instead of RSA
- re-enable testJWTEncoder, testJWTDecoder and testJWTCoderCycle
@wassup-
rename incorrectly named digest parameter to data
d8b75e8
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dannys42
Copy link
Contributor

dannys42 commented Mar 2, 2024

Thanks for this PR. Do you know if RSA has been added to Swift Crypto yet?

@wassup-
add RSA support
99430e9 
- RSA with either public key or private key is supported
- RSA with certificate is not supported
@wassup-
swiftformat
0a45253
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wassup-
Copy link
Author

wassup- commented Mar 3, 2024

@dannys42 It seems like Swift Crypto supports RSA via the _CryptoExtras package.
For this PR I have now added support for RSA using both public- and private keys. Using certificates is not supported.

@wassup- wassup- mentioned this pull request Mar 3, 2024
Open
@Jeehut
Copy link

Jeehut commented Oct 23, 2024 •
edited
Loading

@wassup- Could you review & accept the CLA so this is no longer blocked? I personally need this to get compatibility with visionOS. Thank you for the hard work!

@wassup-
Copy link
Author

wassup- commented Nov 2, 2024

@Jeehut I have signed the CLA, however I'm afraid this repository is kind of abandoned.

Here's to hoping this will be reviewed and possibly even merged soon 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wassup- @CLAassistant @dannys42 @Jeehut