Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typehint on adapter #694

Merged
merged 48 commits into from
Oct 30, 2023
Merged

feat: add typehint on adapter #694

merged 48 commits into from
Oct 30, 2023

Conversation

KevinArtus
Copy link
Contributor

No description provided.

src/Gaufrette/Adapter.php Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter/AwsS3.php Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Show resolved Hide resolved
src/Gaufrette/Adapter/AzureBlobStorage.php Show resolved Hide resolved
src/Gaufrette/Adapter/Flysystem.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter/Flysystem.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter/PhpseclibSftp.php Show resolved Hide resolved
src/Gaufrette/Adapter/PhpseclibSftp.php Outdated Show resolved Hide resolved
@KevinArtus KevinArtus marked this pull request as ready for review May 25, 2023 12:29
@muchafm muchafm force-pushed the feat/add-type-adapter branch 2 times, most recently from 8bd80cc to f16ad45 Compare May 26, 2023 13:23
src/Gaufrette/Adapter/AsyncAwsS3.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter/AwsS3.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter.php Outdated Show resolved Hide resolved
src/Gaufrette/Adapter.php Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Show resolved Hide resolved
src/Gaufrette/Adapter/AsyncAwsS3.php Show resolved Hide resolved
src/Gaufrette/Adapter/AwsS3.php Show resolved Hide resolved
@muchafm muchafm self-requested a review October 30, 2023 14:26
@KevinArtus KevinArtus merged commit 0cb8b54 into v0.12.0 Oct 30, 2023
31 of 33 checks passed
@KevinArtus KevinArtus deleted the feat/add-type-adapter branch October 30, 2023 14:37
@PedroTroller PedroTroller self-assigned this Jan 15, 2024
PedroTroller added a commit that referenced this pull request Feb 26, 2024
* feat: add typehint on adapter

* Type interface for adapters

* Type AsyncAwsS3

* Type AwsS3

* Type AzureBlobStorage

* Type DoctrineDbal

* fix constructor AsyncAwsS3

* Type Flysystem

* Type PhpseclibSftp

* Type Zip

* Type GridFS and fix declaration checksum

* fix muchafm review

* refacto: add types on adapter

* fix: review

* fix: review

* Refacto: Add type on Stream classes

* fix pedro review

* refactor: add typeint to FilesystemMap, StreamWrapper and StreamMode

* Refacto: Add type on Util classes

* fix muchafm review

* fix: pedro review

* fix pedro's review

* refacto: spec types

* fix: review

* refactor: fix Ftp and StreamWrapper errors

* refactor: fix lvl5 errors for AwsS3 and AzureBlobStorage adapters

* ci: upgrade phpstan to 1.10.39

* test: fix filesystem typehint in phpunit tests

* fix: fix phpspec tests

* refactor: apply cs fixing

* test: fix phpspec tests

* Update src/Gaufrette/Adapter/AwsS3.php

Co-authored-by: Grégoire Drapeau <[email protected]>

* Update src/Gaufrette/Adapter/PhpseclibSftp.php

Co-authored-by: Grégoire Drapeau <[email protected]>

* Update src/Gaufrette/Adapter/AzureBlobStorage.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Adapter.php

* Update src/Gaufrette/Adapter/AzureBlobStorage.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Adapter/Ftp.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Adapter/AzureBlobStorage.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Adapter/DoctrineDbal.php

* refactor: set type for mimetype aware adapters

* docs: add explanation for bitwire value in StreamWrapper

* fix: introduction of readonly promoted properties

* Update src/Gaufrette/Adapter/AwsS3.php

Co-authored-by: Grégoire Drapeau <[email protected]>

* Update src/Gaufrette/Stream/InMemoryBuffer.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Stream/Local.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Stream/Local.php

Co-authored-by: Kévin <[email protected]>

* Update src/Gaufrette/Adapter/AsyncAwsS3.php

* Update src/Gaufrette/Stream/InMemoryBuffer.php

Co-authored-by: Kévin <[email protected]>

---------

Co-authored-by: Sophie Roussel <[email protected]>
Co-authored-by: PedroTroller <[email protected]>
Co-authored-by: Grégoire Drapeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants