Integrate Cargo Clippy and probably rustfmt into CI scripts #687 (#690)

* Fix clippy warnings

* Add rustfmt.toml, fix rustfmt docker_tests module resolving

* Remove excess swaps_file_lock_tests module attributes

* Change rustfmt.toml, run "cargo +nightly fmt"

* Add clippy checking to azure pipelines

* Fix cargo clippy using, add display name for the step

* Remove minor mistake

* Fix build.rs clippy warnings, add fmt tool checker

* Fix build.rs fmt warnings

* Add clippy and rustfmt info to README

* Separate common README info and CONTRIBUTING guide

CONTRIBUTING.md

@@ -0,0 +1,29 @@
+# Contributing to AtomicDEX Marketmaker
+
+We welcomes contribution from everyone in the form of suggestions, bug reports, pull requests, and feedback.
+Please note we have a code of conduct, please follow it in all your interactions with the project.
+
+## Submitting feature requests
+
+Before uploading any changes, please make sure that the test suite passes locally before submitting a pull request with your changes.
+
+```
+cargo test --all --features native
+```
+
+We also use [Clippy](https://github.com/rust-lang/rust-clippy) to avoid common mistakes
+and we use [rustfmt](https://github.com/rust-lang/rustfmt) to make our code clear to everyone.
+
+1. Install these tools (only once):
+    ```
+    rustup component add rustfmt --toolchain nightly-2020-02-01
+    rustup component add clippy
+    ```
+1. Format the code using rustfmt:
+    ```
+    cargo +nightly fmt
+    ```
+1. Make sure there are no warnings and errors. Run the Clippy:
+    ```
+    cargo clippy --features native -- -D warnings
+    ```

azure-pipelines-build-stage-job.yml

@@ -53,6 +53,14 @@ jobs:
           BOB_USERPASS: $(${{ parameters.bob_userpass }})
           ALICE_PASSPHRASE: $(${{ parameters.alice_passphrase }})
           ALICE_USERPASS: $(${{ parameters.alice_userpass }})
+      - bash: |
+          cargo clippy --features native -- -D warnings
+        displayName: 'Check Clippy warnings'
+        condition: eq( variables['Agent.OS'], 'Linux' )
+      - bash: |
+          cargo +nightly fmt -- --check
+        displayName: 'Check rustfmt warnings'
+        condition: eq( variables['Agent.OS'], 'Linux' )
       - bash: |
           zip upload/mm2-$(COMMIT_HASH)-$(Agent.OS)-Debug target/debug/mm2 -j
         displayName: 'Prepare debug build upload Linux'

mm2src/coins/coins_tests.rs

@@ -7,37 +7,47 @@ pub fn test_list_unspent() {
     let client = NativeClientImpl {
         coin_ticker: "RICK".into(),
         uri: "http://127.0.0.1:10271".to_owned(),
-        auth: fomat!("Basic " (base64_encode("user481805103:pass97a61c8d048bcf468c6c39a314970e557f57afd1d8a5edee917fb29bafb3a43371", URL_SAFE))),
+        auth: fomat!("Basic "(base64_encode(
+            "user481805103:pass97a61c8d048bcf468c6c39a314970e557f57afd1d8a5edee917fb29bafb3a43371",
+            URL_SAFE
+        ))),
         event_handlers: Default::default(),
     };
     let unspents = client.list_unspent(0, std::i32::MAX, vec!["RBs52D7pVq7txo6SCz1Tuyw2WrPmdqU3qw".to_owned()]);
-    let unspents = unwrap! (unspents.wait());
-    log!("Unspents " [unspents]);
+    let unspents = unwrap!(unspents.wait());
+    log!("Unspents "[unspents]);
 }
 
 pub fn test_get_block_count() {
     let client = NativeClientImpl {
         coin_ticker: "RICK".into(),
         uri: "http://127.0.0.1:10271".to_owned(),
-        auth: fomat!("Basic " (base64_encode("user481805103:pass97a61c8d048bcf468c6c39a314970e557f57afd1d8a5edee917fb29bafb3a43371", URL_SAFE))),
+        auth: fomat!("Basic "(base64_encode(
+            "user481805103:pass97a61c8d048bcf468c6c39a314970e557f57afd1d8a5edee917fb29bafb3a43371",
+            URL_SAFE
+        ))),
         event_handlers: Default::default(),
     };
-    let block_count = unwrap! (client.validate_address("RBs52D7pVq7txo6SCz1Tuyw2WrPmdqU3qw".to_owned()).wait());
-    log!("Block count " [block_count]);
+    let block_count = unwrap!(client
+        .validate_address("RBs52D7pVq7txo6SCz1Tuyw2WrPmdqU3qw".to_owned())
+        .wait());
+    log!("Block count "[block_count]);
 }
 
 pub fn test_import_address() {
     let client = NativeClientImpl {
         coin_ticker: "RICK".into(),
         uri: "http://127.0.0.1:10271".to_owned(),
-        auth: fomat!("Basic " (base64_encode("user481805103:pass97a61c8d048bcf468c6c39a314970e557f57afd1d8a5edee917fb29bafb3a43371", URL_SAFE))),
+        auth: fomat!("Basic "(base64_encode(
+            "user481805103:pass97a61c8d048bcf468c6c39a314970e557f57afd1d8a5edee917fb29bafb3a43371",
+            URL_SAFE
+        ))),
         event_handlers: Default::default(),
     };
     let import_addr = client.import_address(
         "bMjWGCinft5qEvsuf9Wg1fgz1CjpXBXbTB",
         "bMjWGCinft5qEvsuf9Wg1fgz1CjpXBXbTB",
-        true
+        true,
     );
-    let import_addr = import_addr.wait().unwrap();
-    log!("Block count " [import_addr]);
+    import_addr.wait().unwrap();
 }