Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): unlock wasm-pack version #2307

Merged
merged 2 commits into from
Dec 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ RUN apt-get install -y \

RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --profile minimal --default-toolchain nightly-2023-06-01 -y
ENV PATH="/root/.cargo/bin:$PATH"
RUN cargo install wasm-pack --version 0.10.3
# TODO: Lock wasm-pack version
RUN curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | bash -s -- -y
RUN wget https://github.com/protocolbuffers/protobuf/releases/download/v25.3/protoc-25.3-linux-x86_64.zip
RUN unzip protoc-25.3-linux-x86_64.zip && mv ./include/google /usr/include/google

3 changes: 2 additions & 1 deletion .github/workflows/dev-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,8 @@ jobs:
rustup target add wasm32-unknown-unknown

- name: Install wasm-pack
run: CARGO_HOME=/root/.cargo cargo install wasm-pack --version 0.10.3
# TODO: Lock wasm-pack version
run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh

- name: Calculate commit hash for PR commit
if: github.event_name == 'pull_request'
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,8 @@ jobs:
rustup target add wasm32-unknown-unknown

- name: Install wasm-pack
run: CARGO_HOME=/root/.cargo cargo install wasm-pack --version 0.10.3
# TODO: Lock wasm-pack version
run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh

- name: Calculate commit hash for PR commit
if: github.event_name == 'pull_request'
Expand Down
2 changes: 1 addition & 1 deletion docs/WASM_BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ To build WASM binary from source, the following prerequisites are required:

1. Install `wasm-pack`
```
cargo install wasm-pack
curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
```
2. OSX specific: install `llvm`
```
Expand Down
Loading