Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kdf-wasm-ops): response type conversion and migrate to js_interop #14

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

takenagain
Copy link
Collaborator

Changes

  • Migrate from dart:js and dart:js_util to dart:js_interop
  • Fix type conversion of JS response objects
  • Improve JS interop and error handling

The original goal was to fix uncaught async errors without a stacktrace, but that appears to be a non-critical bug related to coin activation - breakpoint steps into activation_strategy_base.dart (line 122 yield* strategy.activate(asset, children))

@takenagain takenagain added the bug Something isn't working label Nov 29, 2024
@takenagain takenagain self-assigned this Nov 29, 2024
@takenagain takenagain requested a review from CharlVS November 29, 2024 15:09
@takenagain takenagain marked this pull request as ready for review November 29, 2024 15:09
Copy link
Member

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is spicy.

@CharlVS CharlVS merged commit 2212b06 into dev Dec 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants