Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bestorders overflow #20

Merged
merged 15 commits into from
Dec 22, 2024
Merged

Fix/bestorders overflow #20

merged 15 commits into from
Dec 22, 2024

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Dec 11, 2024

Fixes reported overflow in current RC.

To test:

  • Go to simple dex view
  • Select MARTY, then open the buy coin selection list
  • Confirm no overflow from tickers or values in columns.

Copy link
Collaborator

@ShantanuSharma9873 ShantanuSharma9873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No details are getting displayed at the dropdown.
image

Video Attachment:
https://github.com/user-attachments/assets/c7b31979-3592-4cd7-bdd2-ada0e7e3c264

@smk762
Copy link
Contributor Author

smk762 commented Dec 20, 2024

No details are getting displayed at the dropdown. image

Video Attachment: https://github.com/user-attachments/assets/c7b31979-3592-4cd7-bdd2-ada0e7e3c264

This should be fixed now

Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the errors/warning in log are all gone

image
i wonder though where those high values in screenshot are from... selling 12 VRSC in this case

they are not on Pro view, best orders, when selling the same amount of VRSC
image

@smk762
Copy link
Contributor Author

smk762 commented Dec 21, 2024

image
The high values are actually low values and technically correct, though a non standard scientific notation.
Will fix

@ShantanuSharma9873
Copy link
Collaborator

No details are getting displayed at the dropdown. image
Video Attachment: https://github.com/user-attachments/assets/c7b31979-3592-4cd7-bdd2-ada0e7e3c264

This should be fixed now

The issue is fixed now. Able to see the details perfectly in the dropdown without getting merged.
image

Observed one issue, where the info is missing to get displayed on the 'Orders' & 'History' tabs after placing an swap order successfully and after completing it.
image

Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
looks good now

@smk762 smk762 merged commit b38edb2 into dev Dec 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants