failed to select a version for the requirement `time = "^0.3.20"`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Clippy had exited with the 101 exit code

error[E0277]: the trait bound `&[i64; 1]: rusqlite::Params` is not satisfied --> zcash_client_sqlite/src/wallet/transact.rs:627:21 | 624 | .query_row( | --------- required by a bound introduced by this call ... 627 | &[tx_row], | ^^^^^^^^^ the trait `rusqlite::Params` is not implemented for `&[i64; 1]` | note: required by a bound in `rusqlite::Connection::query_row` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rusqlite-0.28.0/src/lib.rs:666:12 | 664 | pub fn query_row<T, P, F>(&self, sql: &str, params: P, f: F) -> Result<T> | --------- required by a bound in this associated function 665 | where 666 | P: Params, | ^^^^^^ required by this bound in `Connection::query_row` help: consider removing the leading `&`-reference | 627 - &[tx_row], 627 + [tx_row], |

error[E0277]: the trait bound `&[i64; 1]: rusqlite::Params` is not satisfied --> zcash_client_sqlite/src/wallet/transact.rs:614:21 | 611 | .query_row( | --------- required by a bound introduced by this call ... 614 | &[tx_row], | ^^^^^^^^^ the trait `rusqlite::Params` is not implemented for `&[i64; 1]` | note: required by a bound in `rusqlite::Connection::query_row` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rusqlite-0.28.0/src/lib.rs:666:12 | 664 | pub fn query_row<T, P, F>(&self, sql: &str, params: P, f: F) -> Result<T> | --------- required by a bound in this associated function 665 | where 666 | P: Params, | ^^^^^^ required by this bound in `Connection::query_row` help: consider removing the leading `&`-reference | 614 - &[tx_row], 614 + [tx_row], |

failed to select a version for the requirement `time = "^0.3.20"`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Input required and not supplied: path

failed to select a version for the requirement `time = "^0.3.20"`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

failed to select a version for the requirement `time = "^0.3.20"`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

The job was canceled because "wasm32-unknown-unknown" failed.

failed to select a version for the requirement `time = "^0.3.20"`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

error[E0277]: the trait bound `&[i64; 1]: rusqlite::Params` is not satisfied --> zcash_client_sqlite/src/wallet/transact.rs:627:21 | 624 | .query_row( | --------- required by a bound introduced by this call ... 627 | &[tx_row], | ^^^^^^^^^ the trait `rusqlite::Params` is not implemented for `&[i64; 1]` | note: required by a bound in `rusqlite::Connection::query_row` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rusqlite-0.28.0/src/lib.rs:666:12 | 664 | pub fn query_row<T, P, F>(&self, sql: &str, params: P, f: F) -> Result<T> | --------- required by a bound in this associated function 665 | where 666 | P: Params, | ^^^^^^ required by this bound in `Connection::query_row` help: consider removing the leading `&`-reference | 627 - &[tx_row], 627 + [tx_row], |

error[E0277]: the trait bound `&[i64; 1]: rusqlite::Params` is not satisfied --> zcash_client_sqlite/src/wallet/transact.rs:614:21 | 611 | .query_row( | --------- required by a bound introduced by this call ... 614 | &[tx_row], | ^^^^^^^^^ the trait `rusqlite::Params` is not implemented for `&[i64; 1]` | note: required by a bound in `rusqlite::Connection::query_row` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rusqlite-0.28.0/src/lib.rs:666:12 | 664 | pub fn query_row<T, P, F>(&self, sql: &str, params: P, f: F) -> Result<T> | --------- required by a bound in this associated function 665 | where 666 | P: Params, | ^^^^^^ required by this bound in `Connection::query_row` help: consider removing the leading `&`-reference | 614 - &[tx_row], 614 + [tx_row], |

The job was canceled because "ubuntu-latest" failed.

The operation was canceled.

Clippy had exited with the 101 exit code

The job was canceled because "ubuntu-latest" failed.

The operation was canceled.

Broken pipe (os error 32)

could not compile `bitvec` (lib) due to 1 previous error

cannot find attribute `skip` in this scope

The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/lib.rs:477:50 | 477 | let tx_ref = wallet::put_tx_data(up, &sent_tx.tx, Some(sent_tx.created))?; | ^^^^^^^^^^^ help: change this to: `sent_tx.tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/lib.rs:415:54 | 415 | let tx_row = wallet::put_tx_meta(up, &tx, block.block_height)?; | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/lib.rs:410:17 | 410 | &block.commitment_tree, | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `block.commitment_tree` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/lib.rs:395:6 | 395 | impl<'a, P: consensus::Parameters> WalletWrite for DataConnStmtCache<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 395 - impl<'a, P: consensus::Parameters> WalletWrite for DataConnStmtCache<'a, P> { 395 + impl<P: consensus::Parameters> WalletWrite for DataConnStmtCache<'_, P> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/lib.rs:367:6 | 367 | impl<'a, P: consensus::Parameters> DataConnStmtCache<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 367 - impl<'a, P: consensus::Parameters> DataConnStmtCache<'a, P> { 367 + impl<P: consensus::Parameters> DataConnStmtCache<'_, P> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/lib.rs:282:6 | 282 | impl<'a, P: consensus::Parameters> WalletRead for DataConnStmtCache<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 282 - impl<'a, P: consensus::Parameters> WalletRead for DataConnStmtCache<'a, P> { 282 + impl<P: consensus::Parameters> WalletRead for DataConnStmtCache<'_, P> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:765:25 | 765 | pub fn insert_sent_note<'a, P: consensus::Parameters>( | ^^ 766 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 765 ~ pub fn insert_sent_note<P: consensus::Parameters>( 766 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:718:22 | 718 | pub fn put_sent_note<'a, P: consensus::Parameters>( | ^^ 719 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 718 ~ pub fn put_sent_note<P: consensus::Parameters>( 719 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:680:23 | 680 | pub fn insert_witness<'a, P>( | ^^ 681 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 680 ~ pub fn insert_witness<P>( 681 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:662:55 | 662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?; | ^^^^^^^^^ help: change this to: `sql_args` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:660:54 | 660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 { | ^^^^^^^^^ help: change this to: `sql_args` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:656:10 | 656 | (&":output_index", &output_index), | ^^^^^^^^^^^^^^^^ help: change this to: `":output_index"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:655:10 | 655 | (&":tx", &tx), | ^^^^^^ help: change this to: `":tx"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:654:10 | 654 | (&":is_change", &is_change), | ^^^^^^^^^^^^^ help: change this to: `":is_change"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:653:10 | 653 | (&":memo", &memo), | ^^^^^^^^ help: change this to: `":memo"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:652:10 | 652 | (&":nf", &nf_bytes), | ^^^^^^ help: change this to: `":nf"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:651:10 | 651 | (&":rcm", &rcm), | ^^^^^^^ help: change this to: `":rcm"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:650:10 | 650 | (&":value", &value), | ^^^^^^^^^ help: change this to: `":value"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:649:10 | 649 | (&":diversifier", &diversifier), | ^^^^^^^^^^^^^^^ help: change this to: `":diversifier"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:648:10 | 648 | (&":account", &account), | ^^^^^^^^^^^ help: change this to: `":account"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:631:26 | 631 | pub fn put_received_note<'a, P, T: ShieldedOutput>( | ^^ 632 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 631 ~ pub fn put_received_note<P, T: ShieldedOutput>( 632 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:616:19 | 616 | pub fn mark_spent<'a, P>( | ^^ 617 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 616 ~ pub fn mark_spent<P>( 617 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:578:20 | 578 | pub fn put_tx_data<'a, P>( | ^^ 579 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 578 ~ pub fn put_tx_data<P>( 579 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:551:20 | 551 | pub fn put_tx_meta<'a, P, N>( | ^^ 552 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 551 ~ pub fn put_tx_meta<P, N>( 552 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:529:21 | 529 | pub fn insert_block<'a, P>( | ^^ 530 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 529 ~ pub fn insert_block<P>( 530 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/for_async/mod.rs:363:38 | 363 | update_ops.store_sent_tx(&sent_tx) | ^^^^^^^^ help: change this to: `sent_tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/for_async/mod.rs:350:42 | 350 | update_ops.store_received_tx(&received_tx) | ^^^^^^^^^^^^ help: change this to: `received_tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/for_async/mod.rs:338:41 | 338 | update_ops.advance_by_block(&block, updated_witnesses) | ^^^^^^ help: change this to: `block` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: usage of a legacy numeric method --> zcash_client_sqlite/src/chain.rs:40:62 | 40 | params![u32::from(from_height), limit.unwrap_or(u32::max_value()),], | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]` help: use the associated constant instead | 40 | params![u32::from(from_height), limit.unwrap_or(u32::MAX),], | ~~~

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:662:41 | 662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?; | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:660:40 | 660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 { | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:137:35 | 137 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:79:35 | 79 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:662:41 | 662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?; | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:660:40 | 660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 { | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:137:35 | 137 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:79:35 | 79 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:39:32 | 39 | pub async fn init_blocks_table<P: consensus::Parameters + 'static>( | ^ ... 47 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:23:34 | 23 | pub async fn init_accounts_table<P: consensus::Parameters + 'static>( | ^ ... 28 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:9:29 | 9 | pub async fn init_wallet_db<P: consensus::Parameters + 'static>( | ^ ... 13 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `-W clippy::multiple-bound-locations` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::multiple_bound_locations)]`

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:39:32 | 39 | pub async fn init_blocks_table<P: consensus::Parameters + 'static>( | ^ ... 47 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:23:34 | 23 | pub async fn init_accounts_table<P: consensus::Parameters + 'static>( | ^ ... 28 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:9:29 | 9 | pub async fn init_wallet_db<P: consensus::Parameters + 'static>( | ^ ... 13 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `-W clippy::multiple-bound-locations` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::multiple_bound_locations)]`

warning: useless use of `vec!` --> zcash_primitives/src/transaction/tests.rs:96:21 | 96 | let txn_bytes = vec![ | _____________________^ 97 | | 0xFF, 0xFF, 0x00, 0x80, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x01, 0x52, 0x52, 0x52, 0x52, 98 | | 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 99 | | 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x00, 0x00, ... | 106 | | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 107 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 96 ~ let txn_bytes = [0xFF, 0xFF, 0x00, 0x80, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x01, 0x52, 0x52, 0x52, 0x52, 97 + 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 98 + 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x00, 0x00, 99 + 0x00, 0x00, 0x00, 0x00, 0x20, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 100 + 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 101 + 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x30, 0x75, 0x00, 0x00, 0x00, 0x00, 0x00, 102 + 0x00, 0x00, 0x01, 0x20, 0xd9, 0x81, 0x80, 0x87, 0xde, 0x72, 0x44, 0xab, 0xc1, 0xb5, 0xfc, 103 + 0xf2, 0x8e, 0x55, 0xe4, 0x2c, 0x7f, 0xf9, 0xc6, 0x78, 0xc0, 0x60, 0x51, 0x81, 0xf3, 0x7a, 104 + 0xc5, 0xd7, 0x41, 0x4a, 0x7b, 0x95, 0x00, 0x00, 0x00, 0x00, 0x60, 0x00, 0x00, 0x00, 0x00, 105 ~ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00]; |

warning: useless use of `vec!` --> zcash_primitives/src/legacy.rs:159:30 | 159 | let short_data = vec![2; 100]; | ^^^^^^^^^^^^ help: you can use an array directly: `[2; 100]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-W clippy::useless-vec` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_vec)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/extensions/transparent.rs:150:13 | 150 | &context, | ^^^^^^^^ help: change this to: `context` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/zip32.rs:349:6 | 349 | impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 349 - impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { 349 + impl From<&ExtendedSpendingKey> for ExtendedFullViewingKey { |

warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value --> zcash_primitives/src/zip32.rs:87:17 | 87 | fn to_index(&self) -> u32 { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-W clippy::wrong-self-convention` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::wrong_self_convention)]`

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:495:77 | 495 | is_valid_solution_recursive(tv.params, tv.input, &tv.nonce, &tv.solution) | ^^^^^^^^^^^^ help: change this to: `tv.solution` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:489:77 | 489 | is_valid_solution_iterative(tv.params, tv.input, &tv.nonce, &tv.solution) | ^^^^^^^^^^^^ help: change this to: `tv.solution` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:26 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^^^^^ help: change this to: `state` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:22 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^ help: change this to: `p` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:224:23 | 224 | let len_indices = 8 * size_of::<u32>() * minimal.len() / (c_bit_len + 1); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:173:13 | 173 | assert!(8 * size_of::<u32>() >= 7 + bit_len); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits = note: `-W clippy::manual-bits` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_bits)]`

warning: the borrowed expression implements the required traits --> zcash_primitives/src/transaction/util/sha256d.rs:59:28 | 59 | self.hasher.update(&buf); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:336:17 | 336 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:238:9 | 238 | (&mut personal[..12]).copy_from_slice(ZCASH_SIGHASH_PERSONALIZATION_PREFIX); | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `personal[..12]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:93:9 | 93 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: manual `RangeInclusive::contains` implementation --> zcash_primitives/src/transaction/components/amount.rs:33:12 | 33 | if -MAX_MONEY <= amount && amount <= MAX_MONEY { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-MAX_MONEY..=MAX_MONEY).contains(&amount)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `-W clippy::manual-range-contains` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_range_contains)]`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/transaction/builder.rs:383:6 | 383 | impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 383 - impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { 383 + impl<P: consensus::Parameters> Builder<'_, P, OsRng> { |

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/transaction/builder.rs:323:50 | 323 | builder: Box::new(move |ctx| builder(&ctx).map(|x| x.to_payload())), | ^^^^ help: change this to: `ctx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: use of `default` to create a unit struct --> zcash_primitives/src/transaction/builder.rs:146:33 | 146 | _params: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:404:9 | 404 | (&mut note_contents) | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `note_contents` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:153:5 | 153 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:461:31 | 461 | .open_to(&mut op, &out_ciphertext, &[], ock.as_ref(), &[0u8; 12]) | ^^^^^^^^^^^^^^^ help: change this to: `out_ciphertext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:423:41 | 423 | let shared_secret = D::ka_agree_dec(&ivk, output.epk()); | ^^^^ help: change this to: `ivk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:57 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^^^^^^^^ help: change this to: `derived_esk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:50 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:391:28 | 391 | D::check_epk_bytes(&note, |derived_esk| { | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:387:56 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `map_or` can be simplified --> components/zcash_note_encryption/src/lib.rs:387:8 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ________^ 388 | | .map_or(false, |cs| &cs == cmstar_bytes) | |________________________________________________^ help: use is_ok_and instead: `D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)).is_ok_and(|cs| &cs == cmstar_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:373:72 | 373 | let (note, to) = domain.parse_note_plaintext_without_memo_ivk(ivk, &plaintext)?; | ^^^^^^^^^^ help: change this to: `plaintext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:47 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^^^^^ help: change this to: `cmstar` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:42 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^ help: change this to: `cv` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/sapling/redjubjub.rs:160:21 | 160 | pub fn batch_verify<'a, R: RngCore>( | ^^ 161 | mut rng: &mut R, 162 | batch: &[BatchEntry<'a>], | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 160 ~ pub fn batch_verify<R: RngCore>( 161 | mut rng: &mut R, 162 ~ batch: &[BatchEntry<'_>], |

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_primitives/src/sapling/prover.rs:109:32 | 109 | let rk = PublicKey(proof_generation_key.ak.clone().into()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/pedersen_hash.rs:90:13 | 90 | &generators.next().expect("we don't have enough generators"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `generators.next().expect("we don't have enough generators")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> zcash_primitives/src/sapling/pedersen_hash.rs:41:16 | 41 | .chain(bits.into_iter()); | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `bits` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/transparent/demo.rs:102:12 | 102 | fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 102 - fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { 102 + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:98:15 | 98 | fn verify<'a>( | ^^ ... 102 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 98 ~ fn verify( 99 | &self, 100 | precondition: &Precondition, 101 | witness: &Witness, 102 ~ ctx: &Context<'_>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:77:6 | 77 | impl<'a> demo::Context for Context<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 77 - impl<'a> demo::Context for Context<'a> { 77 + impl demo::Context for Context<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:67:15 | 67 | fn verify<'a>( | ^^ ... 71 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 67 ~ fn verify( 68 | &self, 69 | precondition: &Precondition, 70 | witness: &Witness, 71 ~ ctx: &Context<'_>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/transparent/demo.rs:564:10 | 564 | impl<'a> Context for Ctx<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 564 - impl<'a> Context for Ctx<'a> { 564 + impl Context for Ctx<'_> { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:584:59 | 584 | .seal_to(enc_ciphertext, &plaintext, &[], &key.as_bytes(), &[0u8; 12]) | ^^^^^^^^^^^^^^^ help: change this to: `key.as_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:565:57 | 565 | let key = kdf_sapling(shared_secret, &epk_bytes(&epk)); | ^^^^ help: change this to: `epk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/transparent/demo.rs:102:12 | 102 | fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 102 - fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { 102 + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:98:15 | 98 | fn verify<'a>( | ^^ ... 102 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 98 ~ fn verify( 99 | &self, 100 | precondition: &Precondition, 101 | witness: &Witness, 102 ~ ctx: &Context<'_>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:77:6 | 77 | impl<'a> demo::Context for Context<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 77 - impl<'a> demo::Context for Context<'a> { 77 + impl demo::Context for Context<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:67:15 | 67 | fn verify<'a>( | ^^ ... 71 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 67 ~ fn verify( 68 | &self, 69 | precondition: &Precondition, 70 | witness: &Witness, 71 ~ ctx: &Context<'_>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:550:38 | 550 | let ock = prf_ock(&ovk, &cv, &cmu, &epk_bytes(epk)); | ^^^^ help: change this to: `cmu` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:550:33 | 550 | let ock = prf_ock(&ovk, &cv, &cmu, &epk_bytes(epk)); | ^^^ help: change this to: `cv` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:550:27 | 550 | let ock = prf_ock(&ovk, &cv, &cmu, &epk_bytes(epk)); | ^^^^ help: change this to: `ovk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:414:13 | 414 | &ovk, | ^^^^ help: change this to: `ovk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:262:51 | 262 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:250:51 | 250 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `impl` can be derived --> zcash_primitives/src/memo.rs:175:1 | 175 | / impl Default for Memo { 176 | | fn default() -> Self { 177 | | Memo::Empty 178 | | } 179 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` help: replace the manual implementation with a derive attribute and mark the default variant | 149 + #[derive(Default)] 150 ~ pub enum Memo { 151 | /// An empty memo field. 152 ~ #[default] 153 ~ Empty, |

warning: usage of a legacy numeric method --> zcash_primitives/src/constants.rs:294:35 | 294 | assert!(tag[i] != u8::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]` help: use the associated constant instead | 294 | assert!(tag[i] != u8::MAX); | ~~~

warning: this `map_or` can be simplified --> zcash_primitives/src/consensus.rs:135:9 | 135 | self.activation_height(nu).map_or(false, |h| h <= height) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `self.activation_height(nu).is_some_and(|h| h <= height)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/block.rs:33:30 | 33 | hash.copy_from_slice(&bytes); | ^^^^^^ help: change this to: `bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: fields `p_enc` and `op` are never read --> zcash_primitives/src/test_vectors/note_encryption.rs:15:9 | 1 | pub(crate) struct TestVector { | ---------- fields in this struct ... 15 | pub p_enc: [u8; 564], | ^^^^^ ... 18 | pub op: [u8; 64], | ^^ | = note: `#[warn(dead_code)]` on by default

warning: variable does not need to be mutable --> zcash_primitives/src/transaction/builder.rs:850:17 | 850 | let mut current = self.mtx.tze_inputs.get_mut(i).unwrap(); | ----^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: useless use of `vec!` --> zcash_proofs/src/circuit/sapling.rs:683:34 | 683 | let expected_commitment_vs = vec![ | __________________________________^ 684 | | "27630722367128086497290371604583225252915685718989450292520883698391703910", 685 | | "23310648738313092772044712773481584369462075017189681529702825235349449805260", 686 | | "25709635353183537915646348052945798827495141780341329896098121888376871589480", ... | 693 | | "32959334601512756708397683646222389414681003290313255304927423560477040775488", 694 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 683 ~ let expected_commitment_vs = ["27630722367128086497290371604583225252915685718989450292520883698391703910", 684 + "23310648738313092772044712773481584369462075017189681529702825235349449805260", 685 + "25709635353183537915646348052945798827495141780341329896098121888376871589480", 686 + "10516315852014492141081718791576479298042117442649432716255936672048164184691", 687 + "23970713991179488695004801139667700217127937225554773561645815034212389459772", 688 + "3256052161046564597126736968199320852691566092694819239485673781545479548450", 689 + "18887250722195819674378865377623103071236046274361890247643850134985809137409", 690 + "36501156873031641173054592888886902104303750771545647842488588827138867116570", 691 + "21927526310070011864833939629345235038589128172309792087590183778192091594775", 692 ~ "32959334601512756708397683646222389414681003290313255304927423560477040775488"]; |

warning: useless use of `vec!` --> zcash_proofs/src/circuit/sapling.rs:670:34 | 670 | let expected_commitment_us = vec![ | __________________________________^ 671 | | "43821661663052659750276289184181083197337192946256245809816728673021647664276", 672 | | "7220807656052227578299730541645543434083158611414003423211850718229633594616", 673 | | "13239753550660714843257636471668037031928211668773449453628093339627668081697", ... | 680 | | "18269767207277008186871145355531741929166733260352590789136389380124992250945", 681 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-W clippy::useless-vec` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_vec)]` help: you can use an array directly | 670 ~ let expected_commitment_us = ["43821661663052659750276289184181083197337192946256245809816728673021647664276", 671 + "7220807656052227578299730541645543434083158611414003423211850718229633594616", 672 + "13239753550660714843257636471668037031928211668773449453628093339627668081697", 673 + "10900524635678389360790699587556574797582192824300145558807405770494079767974", 674 + "1411013767457690636461779630023011774660680126764323588543800715293173598850", 675 + "32334206652383066267661379202183359608706535021387905923603014648832344657662", 676 + "20206750741605167608500278423400565295188703622528437817438897624149653579380", 677 + "46716485782200334735478719487356079850582051575003452698983255860512578229998", 678 + "31221372899739042781372142393132358519434268512685538373976981051223051220367", 679 ~ "18269767207277008186871145355531741929166733260352590789136389380124992250945"]; |

warning: the borrowed expression implements the required traits --> zcash_proofs/src/lib.rs:163:37 | 163 | VerifyingKey::<Bls12>::read(&mut fs) | ^^^^^^^ help: change this to: `fs` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:161:9 | 161 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:62:9 | 62 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/prover.rs:247:9 | 247 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_proofs/src/sapling/prover.rs:90:23 | 90 | PublicKey(proof_generation_key.ak.clone().into()).randomize(ar, SPENDING_KEY_GENERATOR); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:460:40 | 460 | .write_u64::<LittleEndian>(vpub_new.unwrap()) | ^^^^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:413:24 | 413 | let vpub_new = Some(test_vector.read_u64::<LittleEndian>().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:457:40 | 457 | .write_u64::<LittleEndian>(vpub_old.unwrap()) | ^^^^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:412:24 | 412 | let vpub_old = Some(test_vector.read_u64::<LittleEndian>().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:449:32 | 449 | expected_inputs.extend(h_sig.unwrap().to_vec()); | ^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:362:21 | 362 | let h_sig = Some(get_u256(&mut test_vector)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:448:32 | 448 | expected_inputs.extend(rt.unwrap().to_vec()); | ^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:361:18 | 361 | let rt = Some(get_u256(&mut test_vector)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap = note: `-W clippy::unnecessary-literal-unwrap` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_literal_unwrap)]`

warning: dereferencing a tuple pattern where every element takes a reference --> zcash_proofs/src/circuit/sprout/input.rs:69:37 | 69 | layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `-W clippy::needless-borrowed-reference` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrowed_reference)]` help: try removing the `&` and `ref` parts | 69 - layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), 69 + layer.as_ref().map(|(sibling, _)| &sibling[..]), |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_proofs/src/circuit/sapling.rs:740:45 | 740 | bls12_381::Scalar::from_str(&expected_commitment_vs[i as usize]).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `expected_commitment_vs[i as usize]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_proofs/src/circuit/sapling.rs:736:45 | 736 | bls12_381::Scalar::from_str(&expected_commitment_us[i as usize]).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `expected_commitment_us[i as usize]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: manually reimplementing `div_ceil` --> zcash_proofs/src/circuit/pedersen_hash.rs:125:24 | 125 | let segments = (chunks + 63 - 1) / 63; | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `chunks.div_ceil(63)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil

warning: manually reimplementing `div_ceil` --> zcash_proofs/src/circuit/pedersen_hash.rs:124:22 | 124 | let chunks = (personalized_bits + 3 - 1) / 3; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `personalized_bits.div_ceil(3)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil = note: `-W clippy::manual-div-ceil` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_div_ceil)]`

warning: accessing first element with `chunk.get(0)` --> zcash_proofs/src/circuit/ecc.rs:39:23 | 39 | let chunk_a = chunk | _______________________^ 40 | | .get(0) | |___________________^ help: try: `chunk.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_history/src/tree.rs:294:6 | 294 | impl<'a> IndexedNode<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 294 - impl<'a> IndexedNode<'a> { 294 + impl IndexedNode<'_> { |

warning: accessing first element with `peaks.get(0)` --> zcash_history/src/tree.rs:248:29 | 248 | let mut new_root = *peaks.get(0).expect("At lest 1 elements in peaks"); | ^^^^^^^^^^^^ help: try: `peaks.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the borrowed expression implements the required traits --> zcash_history/src/node_data.rs:239:59 | 239 | TestResult::from_bool(NodeData::from_bytes(0, &node_data.to_bytes()).unwrap() == node_data) | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `node_data.to_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_history/src/tree.rs:294:6 | 294 | impl<'a> IndexedNode<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 294 - impl<'a> IndexedNode<'a> { 294 + impl IndexedNode<'_> { |

warning: accessing first element with `peaks.get(0)` --> zcash_history/src/tree.rs:248:29 | 248 | let mut new_root = *peaks.get(0).expect("At lest 1 elements in peaks"); | ^^^^^^^^^^^^ help: try: `peaks.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_backend/src/zip321.rs:562:25 | 562 | fn to_indexed_param<'a, P: consensus::Parameters>( | ^^ 563 | params: &'a P, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 562 ~ fn to_indexed_param<P: consensus::Parameters>( 563 ~ params: &P, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:233:51 | 233 | if parse::has_duplicate_param(&current, &p.param) { | ^^^^^^^^ help: change this to: `current` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:195:51 | 195 | ... .chain(payment_params(&payment, Some(i))) | ^^^^^^^^ help: change this to: `payment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:176:51 | 176 | let query_params = payment_params(&payment, None) | ^^^^^^^^ help: change this to: `payment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:169:76 | 169 | .map(move |(name, value)| render::str_param(&name, &value, payment_index)), | ^^^^^^ help: change this to: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:169:69 | 169 | .map(move |(name, value)| render::str_param(&name, &value, payment_index)), | ^^^^^ help: change this to: `name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:163:63 | 163 | .map(|m| render::str_param("message", &m, payment_index)), | ^^ help: change this to: `m` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:157:61 | 157 | .map(|m| render::str_param("label", &m, payment_index)), | ^^ help: change this to: `m` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:151:53 | 151 | .map(|m| render::memo_param(&m, payment_index)), | ^^ help: change this to: `m` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/welding_rig.rs:70:54 | 70 | let is_change = spent_from_accounts.contains(&account); | ^^^^^^^^ help: change this to: `account` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `impl` can be derived --> zcash_client_backend/src/wallet.rs:18:1 | 18 | / impl Default for AccountId { 19 | | fn default() -> Self { 20 | | AccountId(0) 21 | | } 22 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` help: replace the manual implementation with a derive attribute | 16 + #[derive(Default)] 17 ~ pub struct AccountId(pub u32); |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/keys.rs:27:38 | 27 | &ExtendedSpendingKey::master(&seed), | ^^^^^ help: change this to: `seed` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: redundant closure --> zcash_client_backend/src/encoding.rs:33:47 | 33 | Vec::<u8>::from_base32(&data).map(|data| read(data)) | ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `read` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-W clippy::redundant-closure` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::redundant_closure)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/data_api/wallet.rs:225:77 | 225 | RecipientAddress::Transparent(to) => builder.add_transparent_output(&to, value), | ^^^ help: change this to: `to` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons --> zcash_client_backend/src/proto/compact_formats.rs:11:10 | 11 | #![allow(box_pointers)] | ^^^^^^^^^^^^ | = note: `#[warn(renamed_and_removed_lints)]` on by default

warning: the borrowed expression implements the required traits --> zcash_proofs/src/lib.rs:163:37 | 163 | VerifyingKey::<Bls12>::read(&mut fs) | ^^^^^^^ help: change this to: `fs` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:161:9 | 161 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:62:9 | 62 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/prover.rs:247:9 | 247 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_proofs/src/sapling/prover.rs:90:23 | 90 | PublicKey(proof_generation_key.ak.clone().into()).randomize(ar, SPENDING_KEY_GENERATOR); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: dereferencing a tuple pattern where every element takes a reference --> zcash_proofs/src/circuit/sprout/input.rs:69:37 | 69 | layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `-W clippy::needless-borrowed-reference` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrowed_reference)]` help: try removing the `&` and `ref` parts | 69 - layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), 69 + layer.as_ref().map(|(sibling, _)| &sibling[..]), |

warning: accessing first element with `chunk.get(0)` --> zcash_proofs/src/circuit/ecc.rs:39:23 | 39 | let chunk_a = chunk | _______________________^ 40 | | .get(0) | |___________________^ help: try: `chunk.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the borrowed expression implements the required traits --> zcash_client_backend/build.rs:5:19 | 5 | .includes(&["proto"]) | ^^^^^^^^^^ help: change this to: `["proto"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> zcash_client_backend/build.rs:4:17 | 4 | .inputs(&["proto/compact_formats.proto"]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["proto/compact_formats.proto"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/extensions/transparent.rs:150:13 | 150 | &context, | ^^^^^^^^ help: change this to: `context` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/zip32.rs:349:6 | 349 | impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 349 - impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { 349 + impl From<&ExtendedSpendingKey> for ExtendedFullViewingKey { |

warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value --> zcash_primitives/src/zip32.rs:87:17 | 87 | fn to_index(&self) -> u32 { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-W clippy::wrong-self-convention` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::wrong_self_convention)]`

warning: the borrowed expression implements the required traits --> zcash_primitives/src/transaction/util/sha256d.rs:59:28 | 59 | self.hasher.update(&buf); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:336:17 | 336 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:238:9 | 238 | (&mut personal[..12]).copy_from_slice(ZCASH_SIGHASH_PERSONALIZATION_PREFIX); | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `personal[..12]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:93:9 | 93 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: manual `RangeInclusive::contains` implementation --> zcash_primitives/src/transaction/components/amount.rs:33:12 | 33 | if -MAX_MONEY <= amount && amount <= MAX_MONEY { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-MAX_MONEY..=MAX_MONEY).contains(&amount)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `-W clippy::manual-range-contains` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_range_contains)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/transaction/builder.rs:383:6 | 383 | impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 383 - impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { 383 + impl<P: consensus::Parameters> Builder<'_, P, OsRng> { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/transaction/builder.rs:323:50 | 323 | builder: Box::new(move |ctx| builder(&ctx).map(|x| x.to_payload())), | ^^^^ help: change this to: `ctx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: use of `default` to create a unit struct --> zcash_primitives/src/transaction/builder.rs:146:33 | 146 | _params: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:404:9 | 404 | (&mut note_contents) | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `note_contents` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:153:5 | 153 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/sapling/redjubjub.rs:160:21 | 160 | pub fn batch_verify<'a, R: RngCore>( | ^^ 161 | mut rng: &mut R, 162 | batch: &[BatchEntry<'a>], | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 160 ~ pub fn batch_verify<R: RngCore>( 161 | mut rng: &mut R, 162 ~ batch: &[BatchEntry<'_>], |

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_primitives/src/sapling/prover.rs:109:32 | 109 | let rk = PublicKey(proof_generation_key.ak.clone().into()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/pedersen_hash.rs:90:13 | 90 | &generators.next().expect("we don't have enough generators"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `generators.next().expect("we don't have enough generators")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> zcash_primitives/src/sapling/pedersen_hash.rs:41:16 | 41 | .chain(bits.into_iter()); | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `bits` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:414:13 | 414 | &ovk, | ^^^^ help: change this to: `ovk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:262:51 | 262 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:250:51 | 250 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `impl` can be derived --> zcash_primitives/src/memo.rs:175:1 | 175 | / impl Default for Memo { 176 | | fn default() -> Self { 177 | | Memo::Empty 178 | | } 179 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` help: replace the manual implementation with a derive attribute and mark the default variant | 149 + #[derive(Default)] 150 ~ pub enum Memo { 151 | /// An empty memo field. 152 ~ #[default] 153 ~ Empty, |

warning: this `map_or` can be simplified --> zcash_primitives/src/consensus.rs:135:9 | 135 | self.activation_height(nu).map_or(false, |h| h <= height) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `self.activation_height(nu).is_some_and(|h| h <= height)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/block.rs:33:30 | 33 | hash.copy_from_slice(&bytes); | ^^^^^^ help: change this to: `bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/lib.rs:477:50 | 477 | let tx_ref = wallet::put_tx_data(up, &sent_tx.tx, Some(sent_tx.created))?; | ^^^^^^^^^^^ help: change this to: `sent_tx.tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: variable does not need to be mutable --> zcash_primitives/src/transaction/builder.rs:850:17 | 850 | let mut current = self.mtx.tze_inputs.get_mut(i).unwrap(); | ----^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:26 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^^^^^ help: change this to: `state` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/lib.rs:415:54 | 415 | let tx_row = wallet::put_tx_meta(up, &tx, block.block_height)?; | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:22 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^ help: change this to: `p` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/lib.rs:410:17 | 410 | &block.commitment_tree, | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `block.commitment_tree` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:224:23 | 224 | let len_indices = 8 * size_of::<u32>() * minimal.len() / (c_bit_len + 1); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/lib.rs:395:6 | 395 | impl<'a, P: consensus::Parameters> WalletWrite for DataConnStmtCache<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 395 - impl<'a, P: consensus::Parameters> WalletWrite for DataConnStmtCache<'a, P> { 395 + impl<P: consensus::Parameters> WalletWrite for DataConnStmtCache<'_, P> { |

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:173:13 | 173 | assert!(8 * size_of::<u32>() >= 7 + bit_len); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits = note: `-W clippy::manual-bits` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_bits)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/lib.rs:367:6 | 367 | impl<'a, P: consensus::Parameters> DataConnStmtCache<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 367 - impl<'a, P: consensus::Parameters> DataConnStmtCache<'a, P> { 367 + impl<P: consensus::Parameters> DataConnStmtCache<'_, P> { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:461:31 | 461 | .open_to(&mut op, &out_ciphertext, &[], ock.as_ref(), &[0u8; 12]) | ^^^^^^^^^^^^^^^ help: change this to: `out_ciphertext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:423:41 | 423 | let shared_secret = D::ka_agree_dec(&ivk, output.epk()); | ^^^^ help: change this to: `ivk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/lib.rs:282:6 | 282 | impl<'a, P: consensus::Parameters> WalletRead for DataConnStmtCache<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 282 - impl<'a, P: consensus::Parameters> WalletRead for DataConnStmtCache<'a, P> { 282 + impl<P: consensus::Parameters> WalletRead for DataConnStmtCache<'_, P> { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:57 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^^^^^^^^ help: change this to: `derived_esk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:765:25 | 765 | pub fn insert_sent_note<'a, P: consensus::Parameters>( | ^^ 766 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 765 ~ pub fn insert_sent_note<P: consensus::Parameters>( 766 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:50 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:718:22 | 718 | pub fn put_sent_note<'a, P: consensus::Parameters>( | ^^ 719 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 718 ~ pub fn put_sent_note<P: consensus::Parameters>( 719 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:391:28 | 391 | D::check_epk_bytes(&note, |derived_esk| { | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:680:23 | 680 | pub fn insert_witness<'a, P>( | ^^ 681 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 680 ~ pub fn insert_witness<P>( 681 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:387:56 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `map_or` can be simplified --> components/zcash_note_encryption/src/lib.rs:387:8 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ________^ 388 | | .map_or(false, |cs| &cs == cmstar_bytes) | |________________________________________________^ help: use is_ok_and instead: `D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)).is_ok_and(|cs| &cs == cmstar_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:662:55 | 662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?; | ^^^^^^^^^ help: change this to: `sql_args` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:373:72 | 373 | let (note, to) = domain.parse_note_plaintext_without_memo_ivk(ivk, &plaintext)?; | ^^^^^^^^^^ help: change this to: `plaintext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:660:54 | 660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 { | ^^^^^^^^^ help: change this to: `sql_args` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:47 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^^^^^ help: change this to: `cmstar` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:656:10 | 656 | (&":output_index", &output_index), | ^^^^^^^^^^^^^^^^ help: change this to: `":output_index"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:42 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^ help: change this to: `cv` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:655:10 | 655 | (&":tx", &tx), | ^^^^^^ help: change this to: `":tx"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:654:10 | 654 | (&":is_change", &is_change), | ^^^^^^^^^^^^^ help: change this to: `":is_change"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:653:10 | 653 | (&":memo", &memo), | ^^^^^^^^ help: change this to: `":memo"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:652:10 | 652 | (&":nf", &nf_bytes), | ^^^^^^ help: change this to: `":nf"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:651:10 | 651 | (&":rcm", &rcm), | ^^^^^^^ help: change this to: `":rcm"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:650:10 | 650 | (&":value", &value), | ^^^^^^^^^ help: change this to: `":value"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:649:10 | 649 | (&":diversifier", &diversifier), | ^^^^^^^^^^^^^^^ help: change this to: `":diversifier"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/wallet.rs:648:10 | 648 | (&":account", &account), | ^^^^^^^^^^^ help: change this to: `":account"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:631:26 | 631 | pub fn put_received_note<'a, P, T: ShieldedOutput>( | ^^ 632 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 631 ~ pub fn put_received_note<P, T: ShieldedOutput>( 632 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:616:19 | 616 | pub fn mark_spent<'a, P>( | ^^ 617 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 616 ~ pub fn mark_spent<P>( 617 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:578:20 | 578 | pub fn put_tx_data<'a, P>( | ^^ 579 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 578 ~ pub fn put_tx_data<P>( 579 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:551:20 | 551 | pub fn put_tx_meta<'a, P, N>( | ^^ 552 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 551 ~ pub fn put_tx_meta<P, N>( 552 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_sqlite/src/wallet.rs:529:21 | 529 | pub fn insert_block<'a, P>( | ^^ 530 | stmts: &mut DataConnStmtCache<'a, P>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 529 ~ pub fn insert_block<P>( 530 ~ stmts: &mut DataConnStmtCache<'_, P>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/for_async/mod.rs:363:38 | 363 | update_ops.store_sent_tx(&sent_tx) | ^^^^^^^^ help: change this to: `sent_tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/for_async/mod.rs:350:42 | 350 | update_ops.store_received_tx(&received_tx) | ^^^^^^^^^^^^ help: change this to: `received_tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_sqlite/src/for_async/mod.rs:338:41 | 338 | update_ops.advance_by_block(&block, updated_witnesses) | ^^^^^^ help: change this to: `block` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: usage of a legacy numeric method --> zcash_client_sqlite/src/chain.rs:40:62 | 40 | params![u32::from(from_height), limit.unwrap_or(u32::max_value()),], | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]` help: use the associated constant instead | 40 | params![u32::from(from_height), limit.unwrap_or(u32::MAX),], | ~~~

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:662:41 | 662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?; | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:660:40 | 660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 { | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:137:35 | 137 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:79:35 | 79 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:662:41 | 662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?; | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::execute_named`: You can use `execute` with named params now. --> zcash_client_sqlite/src/wallet.rs:660:40 | 660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 { | ^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:137:35 | 137 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated method `rusqlite::Statement::<'_>::query_and_then_named`: You can use `query_and_then` with named params now. --> zcash_client_sqlite/src/wallet/transact.rs:79:35 | 79 | let notes = stmt_select_notes.query_and_then_named::<_, SqliteClientError, _>( | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:39:32 | 39 | pub async fn init_blocks_table<P: consensus::Parameters + 'static>( | ^ ... 47 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:23:34 | 23 | pub async fn init_accounts_table<P: consensus::Parameters + 'static>( | ^ ... 28 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:9:29 | 9 | pub async fn init_wallet_db<P: consensus::Parameters + 'static>( | ^ ... 13 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `-W clippy::multiple-bound-locations` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::multiple_bound_locations)]`

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:39:32 | 39 | pub async fn init_blocks_table<P: consensus::Parameters + 'static>( | ^ ... 47 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:23:34 | 23 | pub async fn init_accounts_table<P: consensus::Parameters + 'static>( | ^ ... 28 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

warning: bound is defined in more than one place --> zcash_client_sqlite/src/for_async/init.rs:9:29 | 9 | pub async fn init_wallet_db<P: consensus::Parameters + 'static>( | ^ ... 13 | P: Clone + Send + Sync, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `-W clippy::multiple-bound-locations` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::multiple_bound_locations)]`

warning: useless use of `vec!` --> zcash_primitives/src/transaction/tests.rs:96:21 | 96 | let txn_bytes = vec![ | _____________________^ 97 | | 0xFF, 0xFF, 0x00, 0x80, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x01, 0x52, 0x52, 0x52, 0x52, 98 | | 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 99 | | 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x00, 0x00, ... | 106 | | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 107 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 96 ~ let txn_bytes = [0xFF, 0xFF, 0x00, 0x80, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x01, 0x52, 0x52, 0x52, 0x52, 97 + 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 98 + 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x52, 0x00, 0x00, 99 + 0x00, 0x00, 0x00, 0x00, 0x20, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 100 + 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 101 + 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x30, 0x75, 0x00, 0x00, 0x00, 0x00, 0x00, 102 + 0x00, 0x00, 0x01, 0x20, 0xd9, 0x81, 0x80, 0x87, 0xde, 0x72, 0x44, 0xab, 0xc1, 0xb5, 0xfc, 103 + 0xf2, 0x8e, 0x55, 0xe4, 0x2c, 0x7f, 0xf9, 0xc6, 0x78, 0xc0, 0x60, 0x51, 0x81, 0xf3, 0x7a, 104 + 0xc5, 0xd7, 0x41, 0x4a, 0x7b, 0x95, 0x00, 0x00, 0x00, 0x00, 0x60, 0x00, 0x00, 0x00, 0x00, 105 ~ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00]; |

warning: useless use of `vec!` --> zcash_primitives/src/legacy.rs:159:30 | 159 | let short_data = vec![2; 100]; | ^^^^^^^^^^^^ help: you can use an array directly: `[2; 100]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-W clippy::useless-vec` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_vec)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/extensions/transparent.rs:150:13 | 150 | &context, | ^^^^^^^^ help: change this to: `context` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/zip32.rs:349:6 | 349 | impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 349 - impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { 349 + impl From<&ExtendedSpendingKey> for ExtendedFullViewingKey { |

warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value --> zcash_primitives/src/zip32.rs:87:17 | 87 | fn to_index(&self) -> u32 { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-W clippy::wrong-self-convention` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::wrong_self_convention)]`

warning: the borrowed expression implements the required traits --> zcash_primitives/src/transaction/util/sha256d.rs:59:28 | 59 | self.hasher.update(&buf); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:336:17 | 336 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:238:9 | 238 | (&mut personal[..12]).copy_from_slice(ZCASH_SIGHASH_PERSONALIZATION_PREFIX); | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `personal[..12]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:93:9 | 93 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: manual `RangeInclusive::contains` implementation --> zcash_primitives/src/transaction/components/amount.rs:33:12 | 33 | if -MAX_MONEY <= amount && amount <= MAX_MONEY { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-MAX_MONEY..=MAX_MONEY).contains(&amount)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `-W clippy::manual-range-contains` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_range_contains)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/transaction/builder.rs:383:6 | 383 | impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 383 - impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { 383 + impl<P: consensus::Parameters> Builder<'_, P, OsRng> { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/transaction/builder.rs:323:50 | 323 | builder: Box::new(move |ctx| builder(&ctx).map(|x| x.to_payload())), | ^^^^ help: change this to: `ctx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: use of `default` to create a unit struct --> zcash_primitives/src/transaction/builder.rs:146:33 | 146 | _params: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:495:77 | 495 | is_valid_solution_recursive(tv.params, tv.input, &tv.nonce, &tv.solution) | ^^^^^^^^^^^^ help: change this to: `tv.solution` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:489:77 | 489 | is_valid_solution_iterative(tv.params, tv.input, &tv.nonce, &tv.solution) | ^^^^^^^^^^^^ help: change this to: `tv.solution` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:26 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^^^^^ help: change this to: `state` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:22 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^ help: change this to: `p` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:404:9 | 404 | (&mut note_contents) | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `note_contents` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:224:23 | 224 | let len_indices = 8 * size_of::<u32>() * minimal.len() / (c_bit_len + 1); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:173:13 | 173 | assert!(8 * size_of::<u32>() >= 7 + bit_len); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits = note: `-W clippy::manual-bits` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_bits)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:153:5 | 153 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/sapling/redjubjub.rs:160:21 | 160 | pub fn batch_verify<'a, R: RngCore>( | ^^ 161 | mut rng: &mut R, 162 | batch: &[BatchEntry<'a>], | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 160 ~ pub fn batch_verify<R: RngCore>( 161 | mut rng: &mut R, 162 ~ batch: &[BatchEntry<'_>], |

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_primitives/src/sapling/prover.rs:109:32 | 109 | let rk = PublicKey(proof_generation_key.ak.clone().into()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/pedersen_hash.rs:90:13 | 90 | &generators.next().expect("we don't have enough generators"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `generators.next().expect("we don't have enough generators")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> zcash_primitives/src/sapling/pedersen_hash.rs:41:16 | 41 | .chain(bits.into_iter()); | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `bits` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:461:31 | 461 | .open_to(&mut op, &out_ciphertext, &[], ock.as_ref(), &[0u8; 12]) | ^^^^^^^^^^^^^^^ help: change this to: `out_ciphertext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:423:41 | 423 | let shared_secret = D::ka_agree_dec(&ivk, output.epk()); | ^^^^ help: change this to: `ivk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:57 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^^^^^^^^ help: change this to: `derived_esk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:50 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:391:28 | 391 | D::check_epk_bytes(&note, |derived_esk| { | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:387:56 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `map_or` can be simplified --> components/zcash_note_encryption/src/lib.rs:387:8 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ________^ 388 | | .map_or(false, |cs| &cs == cmstar_bytes) | |________________________________________________^ help: use is_ok_and instead: `D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)).is_ok_and(|cs| &cs == cmstar_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:373:72 | 373 | let (note, to) = domain.parse_note_plaintext_without_memo_ivk(ivk, &plaintext)?; | ^^^^^^^^^^ help: change this to: `plaintext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:47 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^^^^^ help: change this to: `cmstar` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:42 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^ help: change this to: `cv` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/transparent/demo.rs:102:12 | 102 | fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 102 - fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { 102 + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:98:15 | 98 | fn verify<'a>( | ^^ ... 102 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 98 ~ fn verify( 99 | &self, 100 | precondition: &Precondition, 101 | witness: &Witness, 102 ~ ctx: &Context<'_>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:77:6 | 77 | impl<'a> demo::Context for Context<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 77 - impl<'a> demo::Context for Context<'a> { 77 + impl demo::Context for Context<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:67:15 | 67 | fn verify<'a>( | ^^ ... 71 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 67 ~ fn verify( 68 | &self, 69 | precondition: &Precondition, 70 | witness: &Witness, 71 ~ ctx: &Context<'_>, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:584:59 | 584 | .seal_to(enc_ciphertext, &plaintext, &[], &key.as_bytes(), &[0u8; 12]) | ^^^^^^^^^^^^^^^ help: change this to: `key.as_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:565:57 | 565 | let key = kdf_sapling(shared_secret, &epk_bytes(&epk)); | ^^^^ help: change this to: `epk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:550:38 | 550 | let ock = prf_ock(&ovk, &cv, &cmu, &epk_bytes(epk)); | ^^^^ help: change this to: `cmu` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:550:33 | 550 | let ock = prf_ock(&ovk, &cv, &cmu, &epk_bytes(epk)); | ^^^ help: change this to: `cv` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:550:27 | 550 | let ock = prf_ock(&ovk, &cv, &cmu, &epk_bytes(epk)); | ^^^^ help: change this to: `ovk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:414:13 | 414 | &ovk, | ^^^^ help: change this to: `ovk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:262:51 | 262 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:250:51 | 250 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/transparent/demo.rs:564:10 | 564 | impl<'a> Context for Ctx<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 564 - impl<'a> Context for Ctx<'a> { 564 + impl Context for Ctx<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/transparent/demo.rs:102:12 | 102 | fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 102 - fn fmt<'a>(&self, f: &mut fmt::Formatter<'a>) -> fmt::Result { 102 + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:98:15 | 98 | fn verify<'a>( | ^^ ... 102 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 98 ~ fn verify( 99 | &self, 100 | precondition: &Precondition, 101 | witness: &Witness, 102 ~ ctx: &Context<'_>, |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:77:6 | 77 | impl<'a> demo::Context for Context<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 77 - impl<'a> demo::Context for Context<'a> { 77 + impl demo::Context for Context<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> zcash_extensions/src/consensus/transparent.rs:67:15 | 67 | fn verify<'a>( | ^^ ... 71 | ctx: &Context<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 67 ~ fn verify( 68 | &self, 69 | precondition: &Precondition, 70 | witness: &Witness, 71 ~ ctx: &Context<'_>, |

warning: this `impl` can be derived --> zcash_primitives/src/memo.rs:175:1 | 175 | / impl Default for Memo { 176 | | fn default() -> Self { 177 | | Memo::Empty 178 | | } 179 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` help: replace the manual implementation with a derive attribute and mark the default variant | 149 + #[derive(Default)] 150 ~ pub enum Memo { 151 | /// An empty memo field. 152 ~ #[default] 153 ~ Empty, |

warning: usage of a legacy numeric method --> zcash_primitives/src/constants.rs:294:35 | 294 | assert!(tag[i] != u8::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]` help: use the associated constant instead | 294 | assert!(tag[i] != u8::MAX); | ~~~

warning: this `map_or` can be simplified --> zcash_primitives/src/consensus.rs:135:9 | 135 | self.activation_height(nu).map_or(false, |h| h <= height) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `self.activation_height(nu).is_some_and(|h| h <= height)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/block.rs:33:30 | 33 | hash.copy_from_slice(&bytes); | ^^^^^^ help: change this to: `bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: fields `p_enc` and `op` are never read --> zcash_primitives/src/test_vectors/note_encryption.rs:15:9 | 1 | pub(crate) struct TestVector { | ---------- fields in this struct ... 15 | pub p_enc: [u8; 564], | ^^^^^ ... 18 | pub op: [u8; 64], | ^^ | = note: `#[warn(dead_code)]` on by default

warning: variable does not need to be mutable --> zcash_primitives/src/transaction/builder.rs:850:17 | 850 | let mut current = self.mtx.tze_inputs.get_mut(i).unwrap(); | ----^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: useless use of `vec!` --> zcash_proofs/src/circuit/sapling.rs:683:34 | 683 | let expected_commitment_vs = vec![ | __________________________________^ 684 | | "27630722367128086497290371604583225252915685718989450292520883698391703910", 685 | | "23310648738313092772044712773481584369462075017189681529702825235349449805260", 686 | | "25709635353183537915646348052945798827495141780341329896098121888376871589480", ... | 693 | | "32959334601512756708397683646222389414681003290313255304927423560477040775488", 694 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec help: you can use an array directly | 683 ~ let expected_commitment_vs = ["27630722367128086497290371604583225252915685718989450292520883698391703910", 684 + "23310648738313092772044712773481584369462075017189681529702825235349449805260", 685 + "25709635353183537915646348052945798827495141780341329896098121888376871589480", 686 + "10516315852014492141081718791576479298042117442649432716255936672048164184691", 687 + "23970713991179488695004801139667700217127937225554773561645815034212389459772", 688 + "3256052161046564597126736968199320852691566092694819239485673781545479548450", 689 + "18887250722195819674378865377623103071236046274361890247643850134985809137409", 690 + "36501156873031641173054592888886902104303750771545647842488588827138867116570", 691 + "21927526310070011864833939629345235038589128172309792087590183778192091594775", 692 ~ "32959334601512756708397683646222389414681003290313255304927423560477040775488"]; |

warning: useless use of `vec!` --> zcash_proofs/src/circuit/sapling.rs:670:34 | 670 | let expected_commitment_us = vec![ | __________________________________^ 671 | | "43821661663052659750276289184181083197337192946256245809816728673021647664276", 672 | | "7220807656052227578299730541645543434083158611414003423211850718229633594616", 673 | | "13239753550660714843257636471668037031928211668773449453628093339627668081697", ... | 680 | | "18269767207277008186871145355531741929166733260352590789136389380124992250945", 681 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-W clippy::useless-vec` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_vec)]` help: you can use an array directly | 670 ~ let expected_commitment_us = ["43821661663052659750276289184181083197337192946256245809816728673021647664276", 671 + "7220807656052227578299730541645543434083158611414003423211850718229633594616", 672 + "13239753550660714843257636471668037031928211668773449453628093339627668081697", 673 + "10900524635678389360790699587556574797582192824300145558807405770494079767974", 674 + "1411013767457690636461779630023011774660680126764323588543800715293173598850", 675 + "32334206652383066267661379202183359608706535021387905923603014648832344657662", 676 + "20206750741605167608500278423400565295188703622528437817438897624149653579380", 677 + "46716485782200334735478719487356079850582051575003452698983255860512578229998", 678 + "31221372899739042781372142393132358519434268512685538373976981051223051220367", 679 ~ "18269767207277008186871145355531741929166733260352590789136389380124992250945"]; |

warning: the borrowed expression implements the required traits --> zcash_proofs/src/lib.rs:163:37 | 163 | VerifyingKey::<Bls12>::read(&mut fs) | ^^^^^^^ help: change this to: `fs` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:161:9 | 161 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:62:9 | 62 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/prover.rs:247:9 | 247 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_proofs/src/sapling/prover.rs:90:23 | 90 | PublicKey(proof_generation_key.ak.clone().into()).randomize(ar, SPENDING_KEY_GENERATOR); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:460:40 | 460 | .write_u64::<LittleEndian>(vpub_new.unwrap()) | ^^^^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:413:24 | 413 | let vpub_new = Some(test_vector.read_u64::<LittleEndian>().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:457:40 | 457 | .write_u64::<LittleEndian>(vpub_old.unwrap()) | ^^^^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:412:24 | 412 | let vpub_old = Some(test_vector.read_u64::<LittleEndian>().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:449:32 | 449 | expected_inputs.extend(h_sig.unwrap().to_vec()); | ^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:362:21 | 362 | let h_sig = Some(get_u256(&mut test_vector)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap

warning: used `unwrap()` on `Some` value --> zcash_proofs/src/circuit/sprout/mod.rs:448:32 | 448 | expected_inputs.extend(rt.unwrap().to_vec()); | ^^^^^^^^^^^ | help: remove the `Some` and `unwrap()` --> zcash_proofs/src/circuit/sprout/mod.rs:361:18 | 361 | let rt = Some(get_u256(&mut test_vector)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap = note: `-W clippy::unnecessary-literal-unwrap` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_literal_unwrap)]`

warning: dereferencing a tuple pattern where every element takes a reference --> zcash_proofs/src/circuit/sprout/input.rs:69:37 | 69 | layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `-W clippy::needless-borrowed-reference` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrowed_reference)]` help: try removing the `&` and `ref` parts | 69 - layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), 69 + layer.as_ref().map(|(sibling, _)| &sibling[..]), |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_proofs/src/circuit/sapling.rs:740:45 | 740 | bls12_381::Scalar::from_str(&expected_commitment_vs[i as usize]).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `expected_commitment_vs[i as usize]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_proofs/src/circuit/sapling.rs:736:45 | 736 | bls12_381::Scalar::from_str(&expected_commitment_us[i as usize]).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `expected_commitment_us[i as usize]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: manually reimplementing `div_ceil` --> zcash_proofs/src/circuit/pedersen_hash.rs:125:24 | 125 | let segments = (chunks + 63 - 1) / 63; | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `chunks.div_ceil(63)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil

warning: manually reimplementing `div_ceil` --> zcash_proofs/src/circuit/pedersen_hash.rs:124:22 | 124 | let chunks = (personalized_bits + 3 - 1) / 3; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `personalized_bits.div_ceil(3)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil = note: `-W clippy::manual-div-ceil` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_div_ceil)]`

warning: accessing first element with `chunk.get(0)` --> zcash_proofs/src/circuit/ecc.rs:39:23 | 39 | let chunk_a = chunk | _______________________^ 40 | | .get(0) | |___________________^ help: try: `chunk.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_history/src/tree.rs:294:6 | 294 | impl<'a> IndexedNode<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 294 - impl<'a> IndexedNode<'a> { 294 + impl IndexedNode<'_> { |

warning: accessing first element with `peaks.get(0)` --> zcash_history/src/tree.rs:248:29 | 248 | let mut new_root = *peaks.get(0).expect("At lest 1 elements in peaks"); | ^^^^^^^^^^^^ help: try: `peaks.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the borrowed expression implements the required traits --> zcash_history/src/node_data.rs:239:59 | 239 | TestResult::from_bool(NodeData::from_bytes(0, &node_data.to_bytes()).unwrap() == node_data) | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `node_data.to_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_history/src/tree.rs:294:6 | 294 | impl<'a> IndexedNode<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 294 - impl<'a> IndexedNode<'a> { 294 + impl IndexedNode<'_> { |

warning: accessing first element with `peaks.get(0)` --> zcash_history/src/tree.rs:248:29 | 248 | let mut new_root = *peaks.get(0).expect("At lest 1 elements in peaks"); | ^^^^^^^^^^^^ help: try: `peaks.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_client_backend/src/zip321.rs:562:25 | 562 | fn to_indexed_param<'a, P: consensus::Parameters>( | ^^ 563 | params: &'a P, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 562 ~ fn to_indexed_param<P: consensus::Parameters>( 563 ~ params: &P, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:233:51 | 233 | if parse::has_duplicate_param(&current, &p.param) { | ^^^^^^^^ help: change this to: `current` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:195:51 | 195 | ... .chain(payment_params(&payment, Some(i))) | ^^^^^^^^ help: change this to: `payment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:176:51 | 176 | let query_params = payment_params(&payment, None) | ^^^^^^^^ help: change this to: `payment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:169:76 | 169 | .map(move |(name, value)| render::str_param(&name, &value, payment_index)), | ^^^^^^ help: change this to: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:169:69 | 169 | .map(move |(name, value)| render::str_param(&name, &value, payment_index)), | ^^^^^ help: change this to: `name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:163:63 | 163 | .map(|m| render::str_param("message", &m, payment_index)), | ^^ help: change this to: `m` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:157:61 | 157 | .map(|m| render::str_param("label", &m, payment_index)), | ^^ help: change this to: `m` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/zip321.rs:151:53 | 151 | .map(|m| render::memo_param(&m, payment_index)), | ^^ help: change this to: `m` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/welding_rig.rs:70:54 | 70 | let is_change = spent_from_accounts.contains(&account); | ^^^^^^^^ help: change this to: `account` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `impl` can be derived --> zcash_client_backend/src/wallet.rs:18:1 | 18 | / impl Default for AccountId { 19 | | fn default() -> Self { 20 | | AccountId(0) 21 | | } 22 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` help: replace the manual implementation with a derive attribute | 16 + #[derive(Default)] 17 ~ pub struct AccountId(pub u32); |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/keys.rs:27:38 | 27 | &ExtendedSpendingKey::master(&seed), | ^^^^^ help: change this to: `seed` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: redundant closure --> zcash_client_backend/src/encoding.rs:33:47 | 33 | Vec::<u8>::from_base32(&data).map(|data| read(data)) | ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `read` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-W clippy::redundant-closure` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::redundant_closure)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_backend/src/data_api/wallet.rs:225:77 | 225 | RecipientAddress::Transparent(to) => builder.add_transparent_output(&to, value), | ^^^ help: change this to: `to` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons --> zcash_client_backend/src/proto/compact_formats.rs:11:10 | 11 | #![allow(box_pointers)] | ^^^^^^^^^^^^ | = note: `#[warn(renamed_and_removed_lints)]` on by default

warning: the borrowed expression implements the required traits --> zcash_proofs/src/lib.rs:163:37 | 163 | VerifyingKey::<Bls12>::read(&mut fs) | ^^^^^^^ help: change this to: `fs` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:161:9 | 161 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/verifier.rs:62:9 | 62 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash_value[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_proofs/src/sapling/prover.rs:247:9 | 247 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_proofs/src/sapling/prover.rs:90:23 | 90 | PublicKey(proof_generation_key.ak.clone().into()).randomize(ar, SPENDING_KEY_GENERATOR); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: dereferencing a tuple pattern where every element takes a reference --> zcash_proofs/src/circuit/sprout/input.rs:69:37 | 69 | layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `-W clippy::needless-borrowed-reference` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrowed_reference)]` help: try removing the `&` and `ref` parts | 69 - layer.as_ref().map(|&(ref sibling, _)| &sibling[..]), 69 + layer.as_ref().map(|(sibling, _)| &sibling[..]), |

warning: accessing first element with `chunk.get(0)` --> zcash_proofs/src/circuit/ecc.rs:39:23 | 39 | let chunk_a = chunk | _______________________^ 40 | | .get(0) | |___________________^ help: try: `chunk.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`

warning: the borrowed expression implements the required traits --> zcash_client_backend/build.rs:5:19 | 5 | .includes(&["proto"]) | ^^^^^^^^^^ help: change this to: `["proto"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> zcash_client_backend/build.rs:4:17 | 4 | .inputs(&["proto/compact_formats.proto"]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["proto/compact_formats.proto"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/extensions/transparent.rs:150:13 | 150 | &context, | ^^^^^^^^ help: change this to: `context` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/zip32.rs:349:6 | 349 | impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 349 - impl<'a> From<&'a ExtendedSpendingKey> for ExtendedFullViewingKey { 349 + impl From<&ExtendedSpendingKey> for ExtendedFullViewingKey { |

warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value --> zcash_primitives/src/zip32.rs:87:17 | 87 | fn to_index(&self) -> u32 { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-W clippy::wrong-self-convention` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::wrong_self_convention)]`

warning: the borrowed expression implements the required traits --> zcash_primitives/src/transaction/util/sha256d.rs:59:28 | 59 | self.hasher.update(&buf); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:336:17 | 336 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:238:9 | 238 | (&mut personal[..12]).copy_from_slice(ZCASH_SIGHASH_PERSONALIZATION_PREFIX); | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `personal[..12]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/transaction/sighash.rs:93:9 | 93 | (&mut data) | ^^^^^^^^^^^ help: change this to: `data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: manual `RangeInclusive::contains` implementation --> zcash_primitives/src/transaction/components/amount.rs:33:12 | 33 | if -MAX_MONEY <= amount && amount <= MAX_MONEY { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-MAX_MONEY..=MAX_MONEY).contains(&amount)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `-W clippy::manual-range-contains` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_range_contains)]`

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/transaction/builder.rs:383:6 | 383 | impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 383 - impl<'a, P: consensus::Parameters> Builder<'a, P, OsRng> { 383 + impl<P: consensus::Parameters> Builder<'_, P, OsRng> { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/transaction/builder.rs:323:50 | 323 | builder: Box::new(move |ctx| builder(&ctx).map(|x| x.to_payload())), | ^^^^ help: change this to: `ctx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: use of `default` to create a unit struct --> zcash_primitives/src/transaction/builder.rs:146:33 | 146 | _params: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:404:9 | 404 | (&mut note_contents) | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `note_contents` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow --> zcash_primitives/src/sapling.rs:153:5 | 153 | (&mut data_to_be_signed[32..64]).copy_from_slice(&sighash[..]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_be_signed[32..64]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> zcash_primitives/src/sapling/redjubjub.rs:160:21 | 160 | pub fn batch_verify<'a, R: RngCore>( | ^^ 161 | mut rng: &mut R, 162 | batch: &[BatchEntry<'a>], | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 160 ~ pub fn batch_verify<R: RngCore>( 161 | mut rng: &mut R, 162 ~ batch: &[BatchEntry<'_>], |

warning: using `clone` on type `SubgroupPoint` which implements the `Copy` trait --> zcash_primitives/src/sapling/prover.rs:109:32 | 109 | let rk = PublicKey(proof_generation_key.ak.clone().into()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proof_generation_key.ak` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/pedersen_hash.rs:90:13 | 90 | &generators.next().expect("we don't have enough generators"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `generators.next().expect("we don't have enough generators")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> zcash_primitives/src/sapling/pedersen_hash.rs:41:16 | 41 | .chain(bits.into_iter()); | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `bits` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c94848c046d29f9a80c09aae758e27e418a289f2/library/core/src/iter/traits/iterator.rs:471:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:414:13 | 414 | &ovk, | ^^^^ help: change this to: `ovk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:262:51 | 262 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/sapling/note_encryption.rs:250:51 | 250 | sapling_parse_note_plaintext_without_memo(&self, plaintext, |diversifier| { | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `impl` can be derived --> zcash_primitives/src/memo.rs:175:1 | 175 | / impl Default for Memo { 176 | | fn default() -> Self { 177 | | Memo::Empty 178 | | } 179 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` help: replace the manual implementation with a derive attribute and mark the default variant | 149 + #[derive(Default)] 150 ~ pub enum Memo { 151 | /// An empty memo field. 152 ~ #[default] 153 ~ Empty, |

warning: this `map_or` can be simplified --> zcash_primitives/src/consensus.rs:135:9 | 135 | self.activation_height(nu).map_or(false, |h| h <= height) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `self.activation_height(nu).is_some_and(|h| h <= height)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_primitives/src/block.rs:33:30 | 33 | hash.copy_from_slice(&bytes); | ^^^^^^ help: change this to: `bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: variable does not need to be mutable --> zcash_primitives/src/transaction/builder.rs:850:17 | 850 | let mut current = self.mtx.tze_inputs.get_mut(i).unwrap(); | ----^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:26 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^^^^^ help: change this to: `state` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/equihash/src/verify.rs:317:22 | 317 | Ok(Node::new(&p, &state, indices[0])) | ^^ help: change this to: `p` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:224:23 | 224 | let len_indices = 8 * size_of::<u32>() * minimal.len() / (c_bit_len + 1); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits

warning: usage of `mem::size_of::<T>()` to obtain the size of `T` in bits --> components/equihash/src/verify.rs:173:13 | 173 | assert!(8 * size_of::<u32>() >= 7 + bit_len); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `u32::BITS as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_bits = note: `-W clippy::manual-bits` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_bits)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:461:31 | 461 | .open_to(&mut op, &out_ciphertext, &[], ock.as_ref(), &[0u8; 12]) | ^^^^^^^^^^^^^^^ help: change this to: `out_ciphertext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:423:41 | 423 | let shared_secret = D::ka_agree_dec(&ivk, output.epk()); | ^^^^ help: change this to: `ivk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:57 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^^^^^^^^ help: change this to: `derived_esk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:392:50 | 392 | if D::epk_bytes(&D::ka_derive_public(&note, &derived_esk)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:391:28 | 391 | D::check_epk_bytes(&note, |derived_esk| { | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:387:56 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ^^^^^ help: change this to: `note` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `map_or` can be simplified --> components/zcash_note_encryption/src/lib.rs:387:8 | 387 | if D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)) | ________^ 388 | | .map_or(false, |cs| &cs == cmstar_bytes) | |________________________________________________^ help: use is_ok_and instead: `D::ExtractedCommitmentBytes::try_from(D::cmstar(&note)).is_ok_and(|cs| &cs == cmstar_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:373:72 | 373 | let (note, to) = domain.parse_note_plaintext_without_memo_ivk(ivk, &plaintext)?; | ^^^^^^^^^^ help: change this to: `plaintext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:47 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^^^^^ help: change this to: `cmstar` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> components/zcash_note_encryption/src/lib.rs:295:42 | 295 | let ock = D::derive_ock(ovk, &cv, &cmstar, &D::epk_bytes(&self.epk)); | ^^^ help: change this to: `cv` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/