Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Patryk Małek <[email protected]>
  • Loading branch information
czeslavo and pmalek authored Oct 28, 2024
1 parent 1f00a26 commit a1ff544
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
controlPlaneRef:
type: konnectNamespacedRef
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
' | kubectl apply -f -
```
Expand Down Expand Up @@ -80,7 +80,7 @@ metadata:
namespace: default
spec:
consumerRef:
name: consumer
name: consumer # Reference to the KongConsumer object
password: pass
username: username
' | kubectl apply -f -
Expand Down Expand Up @@ -126,7 +126,7 @@ spec:
controlPlaneRef:
type: konnectNamespacedRef
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
' | kubectl apply -f -
```
Expand Down Expand Up @@ -167,12 +167,12 @@ metadata:
username: consumer
custom_id: 08433C12-2B81-4738-B61D-3AA2136F0212 # Optional
consumerGroups:
- consumer-group # KongConsumerGroup reference
- consumer-group # Reference to the KongConsumerGroup object
spec:
controlPlaneRef:
type: konnectNamespacedRef
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
' | kubectl apply -f -
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ metadata:
namespace: default
spec:
controlPlaneRef:
type: konnectNamespacedRef
type: konnectNamespacedRef # This indicates that an in cluster reference is used
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
kid: key-id
name: key
pem:
Expand Down Expand Up @@ -98,7 +98,7 @@ metadata:
namespace: default
spec:
controlPlaneRef:
type: konnectNamespacedRef
type: konnectNamespacedRef # This indicates that an in cluster reference is used
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
name: key-set
Expand Down Expand Up @@ -138,7 +138,7 @@ metadata:
namespace: default
spec:
controlPlaneRef:
type: konnectNamespacedRef
type: konnectNamespacedRef # This indicates that an in cluster reference is used
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
kid: key-id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ spec:
name: service
host: example.com
controlPlaneRef:
type: konnectNamespacedRef
type: konnectNamespacedRef # This indicates that an in cluster reference is used
konnectNamespacedRef:
name: gateway-control-plane
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
' | kubectl apply -f -
```
Expand Down Expand Up @@ -131,7 +131,7 @@ spec:
controlPlaneRef:
type: konnectNamespacedRef
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
' | kubectl apply -f -
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
controlPlaneRef:
type: konnectNamespacedRef
konnectNamespacedRef:
name: gateway-control-plane
name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object
' | kubectl apply -f -
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ metadata:
spec:
name: upstream
controlPlaneRef:
type: konnectNamespacedRef
type: konnectNamespacedRef # This indicates that an in cluster reference is used
konnectNamespacedRef:
name: gateway-control-plane # KonnectGatewayControlPlane reference
' | kubectl apply -f -
Expand Down Expand Up @@ -75,7 +75,7 @@ metadata:
namespace: default
spec:
upstreamRef:
name: upstream # KongUpstream reference
name: upstream # Reference to the KongUpstream object
target: "10.0.0.1"
weight: 30
---
Expand All @@ -86,7 +86,7 @@ metadata:
namespace: default
spec:
upstreamRef:
name: upstream # KongUpstream reference
name: upstream # Reference to the KongUpstream object
target: "10.0.0.2"
weight: 70
' | kubectl apply -f -
Expand Down

0 comments on commit a1ff544

Please sign in to comment.