Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh security recommendations #7173

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Apr 4, 2024

Description

Testing instructions

Preview link:

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

@lahabana lahabana added the review:copyedit Request for writer review. label Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit dbf8900
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/669e0f3063d227000865084a
😎 Deploy Preview https://deploy-preview-7173--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lahabana lahabana force-pushed the meshSecurityRecommendations branch from ebfb52b to 34a0d7b Compare April 4, 2024 16:54
Signed-off-by: Charly Molter <[email protected]>
@lahabana
Copy link
Contributor Author

lahabana commented Apr 8, 2024

07:40:26 vite.1   | TypeError: Invalid URL
07:40:26 vite.1   |     at new URL (node:internal/url:775:[36](https://github.com/Kong/docs.konghq.com/actions/runs/8558528024/job/23476684430?pr=7173#step:12:37))
07:40:26 vite.1   |     at setHostHeader (/home/runner/work/docs.konghq.com/docs.konghq.com/vite.config.ts:50:16)
07:40:26 vite.1   |     at Object.configure (/home/runner/work/docs.konghq.com/docs.konghq.com/vite.config.ts:96:13)
07:40:26 vite.1   |     at file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/chunks/dep-BBHrJRja.js:63284:18
07:40:26 vite.1   |     at Array.forEach (<anonymous>)
07:[40](https://github.com/Kong/docs.konghq.com/actions/runs/8558528024/job/23476684430?pr=7173#step:12:41):26 vite.1   |     at proxyMiddleware (file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/chunks/dep-BBHrJRja.js:63274:26)
07:40:26 vite.1   |     at _createServer (file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/chunks/dep-BBHrJRja.js:64825:25)
07:40:26 vite.1   |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
07:40:26 vite.1   |     at async CAC.<anonymous> (file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/cli.js:762:24)

@fabianrbz I guess this is due to my cross link to Konnect's docs. Do you know how I should write this to make the test pass?

@mheap
Copy link
Member

mheap commented May 7, 2024

@fabianrbz I ran this locally and all tests passed. What could be the issue?

@fabianrbz
Copy link
Contributor

The issue is that it comes from a fork, and the VITE_PORTAL_API_URL doesn't exist in the forks env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants