Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sso): remove outdated instructions #8127

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(sso): remove outdated instructions #8127

wants to merge 2 commits into from

Conversation

iamnande
Copy link

@iamnande iamnande commented Nov 7, 2024

Description

This removes outdated test & apply instructions regarding SSO setup and verification from both the generic OIDC and Okta specific pages.

Testing instructions

Preview link:

Checklist

@iamnande iamnande self-assigned this Nov 7, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 726a6a5
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/672d49a9bbbc480008c39760
😎 Deploy Preview https://deploy-preview-8127--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 92 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@iamnande iamnande added area/docs review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:copyedit Request for writer review. labels Nov 7, 2024
@iamnande iamnande marked this pull request as ready for review November 7, 2024 23:22
@iamnande iamnande requested a review from a team as a code owner November 7, 2024 23:22
joshcman
joshcman approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@joshcman joshcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamnande iamnande marked this pull request as draft November 8, 2024 05:25
@lena-larionova
Copy link
Contributor

@iamnande should this still be in draft, or is it ready for review & merge? I see that you've received one approval already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcman joshcman joshcman approved these changes

@smritikjaggi smritikjaggi Awaiting requested review from smritikjaggi

At least 1 approving review is required to merge this pull request.

Assignees

@iamnande iamnande

Labels
area/docs review:copyedit Request for writer review. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamnande @lena-larionova @joshcman