Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(envtest): set mock SDK to test creating control plane #573

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Sep 11, 2024

What this PR does / why we need it:
Add settings of mock Konnect SDKs to test creating of Konnect gateway control plane in envtest.
Which issue this PR fixes

Fixes #540

Special notes for your reviewer:
We can add new test cases for reconcilers based on this example.
PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey self-assigned this Sep 11, 2024
@randmonkey randmonkey requested a review from a team as a code owner September 11, 2024 06:55
test/envtest/reconciler_setupwithmanager_test.go Outdated Show resolved Hide resolved
test/envtest/reconciler_setupwithmanager_test.go Outdated Show resolved Hide resolved
controller/konnect/ops/sdkfactory_mock.go Outdated Show resolved Hide resolved
test/envtest/reconciler_setupwithmanager_test.go Outdated Show resolved Hide resolved
@randmonkey randmonkey requested a review from pmalek September 11, 2024 08:55
@randmonkey randmonkey requested a review from pmalek September 11, 2024 10:11
@randmonkey randmonkey enabled auto-merge (squash) September 11, 2024 10:14
@randmonkey randmonkey merged commit 2be5372 into main Sep 11, 2024
21 checks passed
@randmonkey randmonkey deleted the test/envtest_mock_konnect_sdk branch September 11, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use envtest framework in tests requiring a k8s apiserver
2 participants