chore: impersonate KGO RBACs with make _run
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlavacca
changed the title
make run
pmalek
reviewed
Oct 11, 2024
mlavacca
force-pushed
the
mlavacca/make-run-impersonate
branch
4 times, most recently
from
db236e0 to
5a75aff
Compare
|
@pmalek I've addressed both of your comments. Now the target copies the KUBECONFIG into a tmp folder, and sets the new context. Such a TMP_KUBECONFIG is used in _run. Also, the impersonation is a prerequisite to _run. |
mlavacca
changed the title
make runmake _run
pmalek
reviewed
Oct 17, 2024
mlavacca
force-pushed
the
mlavacca/make-run-impersonate
branch
from
5a75aff to
74209ec
Compare
mlavacca
force-pushed
the
mlavacca/make-run-impersonate
branch
from
74209ec to
1029a53
Compare
pmalek
reviewed
Oct 17, 2024
pmalek
reviewed
Oct 18, 2024
mlavacca
force-pushed
the
mlavacca/make-run-impersonate
branch
2 times, most recently
from
448cd70 to
df0c1c2
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
mlavacca/make-run-impersonate
branch
from
df0c1c2 to
372ff63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running
make run, a new context that uses the KGO RBACs is set and used. This way,make runwill allow us to properly test with the actual KGO RBACs, instead of using the admin user.Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes