Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): bump @playwright/test from 1.48.2 to 1.49.0 #332

Merged
merged 2 commits into from
Nov 22, 2024
Merged

chore(deps-dev): bump @playwright/test from 1.48.2 to 1.49.0 #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
859092a
chore(deps-dev): bump @playwright/test from 1.48.2 to 1.49.0
dependabot[bot] Nov 21, 2024
f671d50
test(*): wait for editor
Leopoldthecoder Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"devDependencies": {
"@kong/design-tokens": "^1.17.2",
"@kong/eslint-config-kong-ui": "^1.1.2",
"@playwright/test": "^1.48.2",
"@playwright/test": "^1.49.0",
"@types/lodash-es": "^4.17.12",
"@types/node": "^20.3.1",
"@vitejs/plugin-vue": "^5.1.3",
Expand Down
26 changes: 13 additions & 13 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tests/playwright/specs/routes-expressions/01-Routes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ test.describe('route creation page', () => {

// the editor shows invalid because it is empty
await expect(page.locator('.expression-editor')).toHaveClass(/invalid/)
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -113,6 +114,7 @@ test.describe('route creation page', () => {
await page.locator('#expressions-tab').click()
// should not contain the paths field
await expect(configBlock).not.toContainText(/paths:/)
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -162,6 +164,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand All @@ -186,6 +189,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -213,6 +217,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -245,6 +250,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down
Loading