feat(dashboards and charts): editable tiles | slottable menu items

- add new edit-tile event to dashboard renderer - forward go to explore to analytics chart through tile definition - add new editable property to tile definition that will add an "edit" item to the analytics chart kebab menu. Clicking on edit, will emit an @edit-tile event with the entire GridTile<T> object containing the tile layout, definition and index
Kong · Nov 1, 2024 · e20f568 · e20f568
1 parent f29661f
commit e20f568
Show file tree

Hide file tree

Showing 12 changed files with 146 additions and 93 deletions.
diff --git a/packages/analytics/analytics-chart/src/components/AnalyticsChart.vue b/packages/analytics/analytics-chart/src/components/AnalyticsChart.vue
@@ -68,6 +68,7 @@
               {{ i18n.t('csvExport.exportButton') }}
             </span>
           </KDropdownItem>
+          <slot name="menu-items" />
         </template>
       </KDropdown>
       <!-- Keep outside of dropdown, so we can independently affect its visibility -->

diff --git a/packages/analytics/dashboard-renderer/sandbox/pages/RendererDemo.vue b/packages/analytics/dashboard-renderer/sandbox/pages/RendererDemo.vue
@@ -13,6 +13,7 @@
         :class="{ 'custom-styling': isToggled}"
         :config="(dashboardConfig as DashboardConfig)"
         :context="context"
+        @edit-tile="onEditTile"
       >
         <template #slot-1>
           <div class="slot-container">
@@ -32,7 +33,7 @@
 </template>
 
 <script setup lang="ts">
-import type { DashboardConfig, DashboardRendererContext, TileConfig } from '../../src'
+import type { DashboardConfig, DashboardRendererContext, TileConfig, TileDefinition, GridTile } from '../../src'
 import { DashboardRenderer } from '../../src'
 import { inject, ref } from 'vue'
 import { ChartMetricDisplay } from '@kong-ui-public/analytics-chart'
@@ -135,6 +136,7 @@ const dashboardConfig: DashboardConfig = {
           datasource: 'basic',
           dimensions: ['route'],
         },
+        editable: true,
       },
       layout: {
         position: {
@@ -239,6 +241,10 @@ const dashboardConfig: DashboardConfig = {
 
 const isToggled = ref(false)
 
+const onEditTile = (tile: GridTile<TileDefinition>) => {
+  console.log('@edit-tile', tile)
+}
+
 </script>
 
 <style lang="scss" scoped>

diff --git a/packages/analytics/dashboard-renderer/src/components/BarChartRenderer.vue b/packages/analytics/dashboard-renderer/src/components/BarChartRenderer.vue
@@ -1,42 +1,19 @@
+<!-- BarChartRenderer.vue -->
 <template>
-  <QueryDataProvider
-    v-slot="{ data }"
+  <BaseAnalyticsChartRenderer
+    :chart-options="chartOptions"
     :context="context"
-    :query="query"
+    :definition="definition"
+    :editable="editable"
+    :extra-props="{ showAnnotations: false }"
+    :height="height"
     :query-ready="queryReady"
-  >
-    <div class="analytics-chart">
-      <AnalyticsChart
-        :allow-csv-export="chartOptions.allowCsvExport"
-        :chart-data="data"
-        :chart-options="options"
-        :chart-title="chartOptions.chartTitle"
-        legend-position="bottom"
-        :show-annotations="false"
-        :synthetics-data-key="chartOptions.syntheticsDataKey"
-        tooltip-title=""
-      />
-    </div>
-  </QueryDataProvider>
+  />
 </template>
+
 <script setup lang="ts">
+import BaseAnalyticsChartRenderer from './BaseAnalyticsChartRenderer.vue'
 import type { BarChartOptions, RendererProps } from '../types'
-import QueryDataProvider from './QueryDataProvider.vue'
-import { computed } from 'vue'
-import type { AnalyticsChartOptions } from '@kong-ui-public/analytics-chart'
-import { AnalyticsChart } from '@kong-ui-public/analytics-chart'
-
-const props = defineProps<RendererProps<BarChartOptions>>()
 
-const options = computed((): AnalyticsChartOptions => ({
-  type: props.chartOptions.type,
-  stacked: props.chartOptions.stacked,
-  chartDatasetColors: props.chartOptions.chartDatasetColors,
-}))
+defineProps<RendererProps<BarChartOptions>>()
 </script>
-
-<style scoped lang="scss">
-.analytics-chart {
-  height: v-bind('`${height}px`');
-}
-</style>
diff --git a/packages/analytics/dashboard-renderer/src/components/BaseAnalyticsChartRenderer.vue b/packages/analytics/dashboard-renderer/src/components/BaseAnalyticsChartRenderer.vue
@@ -0,0 +1,61 @@
+<template>
+  <QueryDataProvider
+    v-slot="{ data }"
+    :context="context"
+    :query="definition.query"
+    :query-ready="queryReady"
+  >
+    <div class="analytics-chart">
+      <AnalyticsChart
+        :allow-csv-export="chartOptions.allowCsvExport"
+        :chart-data="data"
+        :chart-options="options"
+        :chart-title="chartOptions.chartTitle"
+        legend-position="bottom"
+        :synthetics-data-key="chartOptions.syntheticsDataKey"
+        tooltip-title=""
+        v-bind="extraProps"
+      >
+        <template
+          v-if="editable"
+          #menu-items
+        >
+          <KDropdownItem @click="editTile">
+            {{ i18n.t('renderer.edit') }}
+          </KDropdownItem>
+        </template>
+      </AnalyticsChart>
+    </div>
+  </QueryDataProvider>
+</template>
+
+<script setup lang="ts">
+import type { RendererProps, TileDefinition } from '../types'
+import QueryDataProvider from './QueryDataProvider.vue'
+import { computed, defineProps } from 'vue'
+import type { AnalyticsChartOptions } from '@kong-ui-public/analytics-chart'
+import { AnalyticsChart } from '@kong-ui-public/analytics-chart'
+import composables from '../composables'
+
+const props = defineProps<RendererProps<any> & { extraProps?: Record<string, any> }>()
+const emit = defineEmits<{
+  (e: 'edit-tile', tile: TileDefinition): void
+}>()
+const { i18n } = composables.useI18n()
+
+const options = computed((): AnalyticsChartOptions => ({
+  type: props.chartOptions.type,
+  stacked: props.chartOptions.stacked ?? false,
+  chartDatasetColors: props.chartOptions.chartDatasetColors,
+}))
+
+const editTile = () => {
+  emit('edit-tile', props.definition)
+}
+</script>
+
+<style scoped lang="scss">
+.analytics-chart {
+  height: v-bind('`${height}px`');
+}
+</style>
diff --git a/packages/analytics/dashboard-renderer/src/components/DashboardRenderer.vue b/packages/analytics/dashboard-renderer/src/components/DashboardRenderer.vue
@@ -26,6 +26,7 @@
           :definition="tile.meta"
           :height="tile.layout.size.rows * (config.tileHeight || DEFAULT_TILE_HEIGHT) + parseInt(KUI_SPACE_70, 10)"
           :query-ready="queryReady"
+          @edit-tile="onEditTile(tile)"
         />
       </template>
     </GridLayout>
@@ -53,6 +54,10 @@ const props = defineProps<{
   config: DashboardConfig,
 }>()
 
+const emit = defineEmits<{
+  (e: 'edit-tile', tile: GridTile<TileDefinition>): void
+}>()
+
 const { i18n } = composables.useI18n()
 
 // Note: queryBridge is not directly used by the DashboardRenderer component.  It is required by many of the
@@ -151,6 +156,10 @@ const mergedContext = computed<DashboardRendererContextInternal>(() => {
 // Right now, tiles don't have unique keys.  Perhaps in the future they will,
 // and we can use that instead of `index` as the fragment key.
 
+const onEditTile = (tile: GridTile<TileDefinition>) => {
+  emit('edit-tile', tile)
+}
+
 </script>
 
 <style lang="scss" scoped>

diff --git a/packages/analytics/dashboard-renderer/src/components/DashboardTile.vue b/packages/analytics/dashboard-renderer/src/components/DashboardTile.vue
@@ -4,6 +4,7 @@
       :is="componentData.component"
       v-if="componentData"
       v-bind="componentData.rendererProps"
+      @edit-tile="onEditTile"
     />
   </div>
 </template>
@@ -34,6 +35,10 @@ const props = withDefaults(defineProps<{
   height: DEFAULT_TILE_HEIGHT,
 })
 
+const emit = defineEmits<{
+  (e: 'edit-tile', tile: TileDefinition): void
+}>()
+
 const rendererLookup: Record<DashboardTileType, Component | undefined> = {
   'timeseries_line': TimeseriesChartRenderer,
   'horizontal_bar': BarChartRenderer,
@@ -51,14 +56,19 @@ const componentData = computed(() => {
   return component && {
     component,
     rendererProps: {
-      query: props.definition.query,
+      definition: props.definition,
       context: props.context,
       queryReady: props.queryReady,
       chartOptions: props.definition.chart,
       height: props.height - PADDING_SIZE * 2,
+      editable: props.definition.editable,
     },
   }
 })
+
+const onEditTile = (definition: TileDefinition) => {
+  emit('edit-tile', definition)
+}
 </script>
 
 <style lang="scss" scoped>

diff --git a/packages/analytics/dashboard-renderer/src/components/GoldenSignalsRenderer.vue b/packages/analytics/dashboard-renderer/src/components/GoldenSignalsRenderer.vue
@@ -46,18 +46,24 @@ const overrideTimeframe: Ref<Timeframe> = computed(() => {
   return relativePeriod
 })
 
-const options = computed<ProviderProps>(() => ({
-  datasource: props.query?.datasource,
-  overrideTimeframe: overrideTimeframe.value,
-  tz: props.context.tz,
-  additionalFilter: props.context.filters as ExploreFilter[], // TODO: Decide how to handle metric card filters.
-  longCardTitles: props.chartOptions.longCardTitles,
-  containerTitle: props.chartOptions.chartTitle,
-  description: props.chartOptions.description,
-  percentileLatency: props.chartOptions.percentileLatency,
-  refreshInterval: props.context.refreshInterval,
-  queryReady: props.queryReady,
-}))
+const options = computed<ProviderProps>(() => {
+  const datasource = props.definition.query?.datasource
+  if (datasource && datasource !== 'advanced' && datasource !== 'basic') {
+    throw new Error(`Invalid datasource value: ${datasource}`)
+  }
+  return {
+    datasource,
+    overrideTimeframe: overrideTimeframe.value,
+    tz: props.context.tz,
+    additionalFilter: props.context.filters as ExploreFilter[], // TODO: Decide how to handle metric card filters.
+    longCardTitles: props.chartOptions.longCardTitles,
+    containerTitle: props.chartOptions.chartTitle,
+    description: props.chartOptions.description,
+    percentileLatency: props.chartOptions.percentileLatency,
+    refreshInterval: props.context.refreshInterval,
+    queryReady: props.queryReady,
+  }
+})
 </script>
 
 <style scoped lang="scss">

diff --git a/packages/analytics/dashboard-renderer/src/components/SimpleChartRenderer.vue b/packages/analytics/dashboard-renderer/src/components/SimpleChartRenderer.vue
@@ -2,7 +2,7 @@
   <QueryDataProvider
     v-slot="{ data }"
     :context="context"
-    :query="query"
+    :query="definition.query"
     :query-ready="queryReady"
   >
     <div class="analytics-chart">

diff --git a/packages/analytics/dashboard-renderer/src/components/TimeseriesChartRenderer.vue b/packages/analytics/dashboard-renderer/src/components/TimeseriesChartRenderer.vue
@@ -1,48 +1,18 @@
+<!-- TimeseriesChartRenderer.vue -->
 <template>
-  <QueryDataProvider
-    v-slot="{ data }"
+  <BaseAnalyticsChartRenderer
+    :chart-options="chartOptions"
     :context="context"
-    :query="query"
+    :definition="definition"
+    :editable="editable"
+    :height="height"
     :query-ready="queryReady"
-  >
-    <div class="analytics-chart">
-      <AnalyticsChart
-        :allow-csv-export="chartOptions.allowCsvExport"
-        :chart-data="data"
-        :chart-options="options"
-        :chart-title="chartOptions.chartTitle"
-        legend-position="bottom"
-        :synthetics-data-key="chartOptions.syntheticsDataKey"
-        tooltip-title=""
-      />
-    </div>
-  </QueryDataProvider>
+  />
 </template>
-<script setup lang="ts">
-import type { RendererProps, TimeseriesChartOptions } from '../types'
-import QueryDataProvider from './QueryDataProvider.vue'
-import { computed } from 'vue'
-import type { AnalyticsChartOptions } from '@kong-ui-public/analytics-chart'
-import { AnalyticsChart } from '@kong-ui-public/analytics-chart'
-
-const props = defineProps<RendererProps<TimeseriesChartOptions>>()
 
-const options = computed((): AnalyticsChartOptions => {
-  // Default `stacked` to false.
-  const stacked = props.chartOptions.stacked ?? false
+<script setup lang="ts">
+import BaseAnalyticsChartRenderer from './BaseAnalyticsChartRenderer.vue'
+import type { TimeseriesChartOptions, RendererProps } from '../types'
 
-  // Note that `fill` and `stacked` are linked; it's not possible to have a non-filled stacked chart.
-  // This matches our intuitions about how these charts work.
-  return {
-    type: props.chartOptions.type,
-    stacked,
-    chartDatasetColors: props.chartOptions.chartDatasetColors,
-  }
-})
+defineProps<RendererProps<TimeseriesChartOptions>>()
 </script>
-
-<style scoped lang="scss">
-.analytics-chart {
-  height: v-bind('`${height}px`');
-}
-</style>
diff --git a/packages/analytics/dashboard-renderer/src/components/TopNTableRenderer.vue b/packages/analytics/dashboard-renderer/src/components/TopNTableRenderer.vue
@@ -2,7 +2,7 @@
   <QueryDataProvider
     v-slot="{ data }"
     :context="context"
-    :query="query"
+    :query="definition.query"
     :query-ready="queryReady"
   >
     <TopNTable

diff --git a/packages/analytics/dashboard-renderer/src/locales/en.json b/packages/analytics/dashboard-renderer/src/locales/en.json
@@ -5,7 +5,8 @@
       "24h": "Last 24-Hour Summary",
       "7d": "Last 7-Day Summary",
       "30d": "Last 30-Day Summary"
-    }
+    },
+    "edit": "Edit"
   },
   "queryDataProvider": {
     "timeRangeExceeded":  "The time range for this report is outside of your organization's data retention period"