fix(entities-plugins): placeholder should reflect actual behavior (#1762

)
Kong · Nov 5, 2024 · eb0dac6 · eb0dac6
1 parent 19ec699
commit eb0dac6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/packages/entities/entities-plugins/src/components/PluginList.vue b/packages/entities/entities-plugins/src/components/PluginList.vue
@@ -113,9 +113,7 @@
       </template>
 
       <template #ordering="{ rowValue }">
-        <KBadge
-          :appearance="isEmpty(rowValue) ? 'info' : 'warning'"
-        >
+        <KBadge :appearance="isEmpty(rowValue) ? 'info' : 'warning'">
           {{
             isEmpty(rowValue)
               ? t('plugins.list.table_headers.ordering_badge.static')
@@ -411,7 +409,8 @@ const filterConfig = computed<InstanceType<typeof EntityFilter>['$props']['confi
         name: fields.name,
         id: { label: t('plugins.list.table_headers.id'), sortable: true },
       },
-      placeholder: t(`search.placeholder.${props.config.app}`),
+      // force exact placeholder if `props.config.isExactMatch` is true
+      placeholder: t(`search.placeholder.${props.config.isExactMatch ? 'exact' : props.config.app}`),
     } as ExactMatchFilterConfig
   }
 
@@ -545,10 +544,9 @@ const confirmSwitchEnablement = async () => {
     return
   }
 
-  let url = `${props.config.apiBaseUrl}${
-    endpoints.item[props.config.app]?.[props.config?.entityType ? 'forEntity' : 'all']
-      .replace(/{entityType}/gi, props.config?.entityType || '')
-      .replace(/{entityId}/gi, props.config?.entityId || '')
+  let url = `${props.config.apiBaseUrl}${endpoints.item[props.config.app]?.[props.config?.entityType ? 'forEntity' : 'all']
+    .replace(/{entityType}/gi, props.config?.entityType || '')
+    .replace(/{entityId}/gi, props.config?.entityId || '')
   }`
     .replace(/{id}/gi, switchEnablementTarget.value.id || '')
 

diff --git a/packages/entities/entities-plugins/src/locales/en.json b/packages/entities/entities-plugins/src/locales/en.json
@@ -53,6 +53,7 @@
   "search": {
     "placeholder": {
       "konnect": "Filter by name",
+      "exact": "Filter by exact instance name or ID",
       "kongManager": "Filter by exact instance name or ID",
       "select": "Filter plugins"
     },