Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): trigger chart and dashboard patch version builds #1738

Closed
wants to merge 2 commits into from

Conversation

mihai-peteu
Copy link
Contributor

@mihai-peteu mihai-peteu requested a review from a team as a code owner October 23, 2024 04:21
@@ -4,6 +4,7 @@ export const chartTypes = [
'vertical_bar',
'timeseries_line',
'timeseries_bar',
'choropleth_map',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the larger Venn diagram that includes all the possible reportChartTypes , therefore should include chloropleth as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to look into it more tomorrow. Map chart type doesn't result in anything this package is capable of so it shouldn't be here 🤔

Copy link
Contributor

@filipgutica filipgutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map chart type should not be going into analytics-chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants