feat(analytics-chart): move actions into kebab menu [MA-3301] #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgutica
force-pushed
the
feat/ma-3301-chart-option-jump-to-explore
branch
3 times, most recently
from
2c7e893 to
a491ead
Compare
CSV export link moved to inside an action menu
filipgutica
force-pushed
the
feat/ma-3301-chart-option-jump-to-explore
branch
from
a491ead to
a4a8a8d
Compare
filipgutica
previously approved these changes
Oct 31, 2024
adorack
previously approved these changes
Oct 31, 2024
| @@ -190,6 +237,9 @@ const emit = defineEmits<{ | |||
| }>() | |||
|
|
|||
| const { i18n } = composables.useI18n() | |||
| const { evaluateFeatureFlag } = composables.useEvaluateFeatureFlag() | |||
|
|
|||
| const hasKebabMenuAccess = computed(() => evaluateFeatureFlag('ma-3043-analytics-chart-kebab-menu', false)) | |||
There was a problem hiding this comment.
FYI, I don't think you need the computed here -- there's nothing reactive and the lookup should be cheap.
adorack
approved these changes
Oct 31, 2024
Justineo
pushed a commit
that referenced
this pull request
Nov 1, 2024
* feat(analytics-chart): move actions into kebab menu [MA-3301] CSV export link moved to inside an action menu * feat(analytics-chart): update component spec [MA-3301] * feat: adding jump to explore link back in [MA-3301] * feat: move modal outside dropdown [MA-3301] * fix: add ff checking * fix: component test * fix: address comment --------- Co-authored-by: Filip Gutica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV export link moved to inside an action menu
Summary
https://konghq.atlassian.net/browse/MA-3301