Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-plugins): wrong custom plugin tab active state [KM-647] #1754

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

2eha0
Copy link
Contributor

@2eha0 2eha0 commented Oct 31, 2024

Summary

KM-647

Reproduction:

  1. accessing a serverless cp
  2. go to the add plugin page
  3. reload the page
  4. the custom plugin tab can be clicked

Expected:
the custom plugin tab should always be disabled under the serverless CP

preview link

`activeTab` is not reactive, causing the custom plugin to activate on the serverless CP
@2eha0 2eha0 marked this pull request as ready for review October 31, 2024 03:05
@2eha0 2eha0 requested review from a team as code owners October 31, 2024 03:05
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2eha0 2eha0 merged commit a101a32 into main Oct 31, 2024
9 checks passed
@2eha0 2eha0 deleted the fix/KM-647 branch October 31, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants