Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-shared): truncate labels in config card items #1800

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Nov 19, 2024

Summary

This pull request fixes the several issues with <ConfigCardItem />:

  1. Incorrect box-sizing
  2. Label text overflows when too long
Before After
Screenshot 2024-11-19 at 12 32 45 2
Screen.Recording.2024-11-20.at.02.36.46.mov

KM-719

@sumimakito sumimakito force-pushed the KM-719-config-card-item branch 4 times, most recently from c8c888a to 0c98d35 Compare November 19, 2024 18:17
@sumimakito sumimakito force-pushed the KM-719-config-card-item branch from 0c98d35 to 9a74679 Compare November 19, 2024 18:29
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for fixing 🙏🏻

@sumimakito sumimakito marked this pull request as ready for review November 19, 2024 18:48
@sumimakito sumimakito requested review from a team as code owners November 19, 2024 18:48
@sumimakito sumimakito merged commit 3a72e0b into main Nov 19, 2024
23 checks passed
@sumimakito sumimakito deleted the KM-719-config-card-item branch November 19, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants