Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert padding change for kebab menu ff #1818

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

filipgutica
Copy link
Contributor

@filipgutica filipgutica commented Nov 26, 2024

Summary

https://konghq.atlassian.net/browse/MA-3465

  • Make the .tile-boundary have display: flex then create a new tile-content div to wrap the component rendered in the tile.
  • Use flex-grow: 1 on the .tile-content so that it takes up available space (taking siblings into account)
  • The analytics chart renderer component can now use height: 100% and it will gracefully stay within the bounds of its container, vertically.

There should be visible effect on users from this change.

@filipgutica filipgutica requested a review from a team as a code owner November 26, 2024 19:00
also improve style and spacing within dashboard tiles to prevent
analytics chart from expanding past the bounds of its container
@filipgutica filipgutica force-pushed the fix/dashboard-revert-padding branch from a9f81ab to 923fbf9 Compare November 26, 2024 19:03
@filipgutica filipgutica merged commit a9a3e6e into main Nov 26, 2024
9 checks passed
@filipgutica filipgutica deleted the fix/dashboard-revert-padding branch November 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants