fix(i18n): formatIsoDate handles trailing 0s #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwylde
requested review from
adamdehaven,
ValeryG,
jillztom and
a team
as code owners
andrewwylde
added
the
create preview package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the date formatting in the i18n module. The most important changes include adding new test cases for various ISO date formats and modifying the
formatIsoDatefunction to exclude milliseconds.This resolves a bug where a timestamp with trailing 0s will result in dividing the number by 1000 twice, resulting in an incorrect date.
Improvements to date formatting:
packages/core/i18n/src/i18n.spec.ts: Added test cases to ensureformatIsoDatecorrectly formats ISO dates with and without milliseconds, and with different time zone offsets.Codebase simplification:
packages/core/i18n/src/i18n.ts: Modified theformatIsoDatefunction to exclude milliseconds by flooring the date value before formatting it.