feat: support new granularities when determining x-axis timestamp format #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgutica
force-pushed
the
fix/analytics-chart-time-label-formats
branch
from
f92b822 to
21d468e
Compare
filipgutica
commented
Dec 12, 2024
| // which is not visible as we're using a custom tooltip. | ||
| // Scaling factor that prevents the tooltip from shifting too far when it's wide, or too little when | ||
| // it's narrow. Ensuring that as the tooltip width changes, the horizontal offset is proportionally | ||
| // adjusted to maintain a visually balanced placement. |
There was a problem hiding this comment.
Just some housekeeping... revisited this old code... thought I'd improve this explanation a bit
|
|
|
|
adorack
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes based off this spreadsheet: https://docs.google.com/spreadsheets/d/1AMShprvxHV15GdGrXLuF9PNVJvmM7bvw9BYRJsl217k/edit?gid=0#gid=0
https://konghq.atlassian.net/browse/MA-3496