Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entities-shared): create shared empty state component [KHCP-14355] #1850

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Dec 12, 2024

Summary

Addresses https://konghq.atlassian.net/browse/KHCP-14355

Creates a shared EntityEmptyState component to be consumed across MFEs in Konnect for L1 items for Milestone 1, then later L1 items for Milestone 2, and potentially in Kong Manager.

Figma: https://www.figma.com/design/5mULvzeW8c3QhGpJvh01wW/Empty-States?node-id=3048-26260&t=KlU5OLVAeTcfHWy9-1

@mptap mptap self-assigned this Dec 12, 2024
@mptap mptap requested a review from kaiarrowood December 13, 2024 20:14
@mptap mptap marked this pull request as ready for review December 13, 2024 21:22
@mptap mptap requested review from a team as code owners December 13, 2024 21:22
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mptap mptap enabled auto-merge (squash) December 13, 2024 21:28
@mptap mptap merged commit 8ac62d5 into main Dec 13, 2024
23 checks passed
@mptap mptap deleted the feat/empty-state-shared-component-khcp-14355 branch December 13, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants