Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entity-empty-state): update pricing prop type and style fixes [khcp-14355] #1852

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix(entity-empty-state): update pricing prop type and style fixes [khcp-14355] #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42c37f3
fix(entity-empty-state): update pricing prop type and style fixes [kh…
mptap Dec 13, 2024
97df0d6
fix(entity-empty-state): use pricing slot in sandbox [khcp-14355]
mptap Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/entities/entities-shared/docs/entity-empty-state.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Description for the empty state.

#### `pricing`

- type: `String`
- default: ``
- type: `Boolean`
- default: false

If provided, will display pricing information for transparency.

Expand Down
5 changes: 4 additions & 1 deletion packages/entities/entities-shared/sandbox/pages/EntityEmptyStatePage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@
description="Lorem ipsum dolor sit amet consectetur adipisicing elit. Id quidem aperiam similique vitae beatae. Repellat quam voluptas vitae, maxime consequuntur praesentium suscipit. Numquam aliquid nulla vel esse accusantium reiciendis error?"
:features="features"
learn-more-link
pricing="Lorem ipsum dolor sit amet consectetur adipisicing elit."
pricing
title="Gateway Manager"
@create-button-clicked="console.log('create button clicked')"
@learning-hub-button-clicked="console.log('learning hub button clicked')"
>
<template #icon>
<RuntimesIcon />
</template>
<template #pricing>
Lorem ipsum dolor sit amet consectetur adipisicing elit
</template>
</EntityEmptyState>
</main>
</div>
Expand Down
14 changes: 9 additions & 5 deletions packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
:color="KUI_COLOR_TEXT_NEUTRAL_STRONGER"
:size="KUI_ICON_SIZE_40"
/>
<div class="card-title">
<div class="card-header">
{{ feature.title }}
</div>
</template>
Expand Down Expand Up @@ -119,8 +119,8 @@ defineProps({
required: true,
},
pricing: {
type: String,
default: '',
type: Boolean,
default: false,
},
actionButtonText: {
type: String,
Expand Down Expand Up @@ -149,7 +149,7 @@ const { i18n: { t } } = composables.useI18n()
display: flex;
flex-direction: column;
font-family: $kui-font-family-text;
gap: $kui-space-100;
gap: $kui-space-90;
padding: $kui-space-130 $kui-space-150;
width: 100%;

Expand Down Expand Up @@ -197,7 +197,7 @@ const { i18n: { t } } = composables.useI18n()
border: $kui-border-width-10 solid $kui-color-border;
border-radius: $kui-border-radius-30;
color: $kui-color-text-neutral-weak;
gap: $kui-space-60;
gap: $kui-space-40;
height: 160px;
padding: $kui-space-80;
width: 312px;
Expand All @@ -207,6 +207,10 @@ const { i18n: { t } } = composables.useI18n()
font-weight: $kui-font-weight-semibold;
}

:deep(.card-header) {
padding-top: $kui-space-40;
}

:deep(.card-content) {
color: $kui-color-text-neutral;
}
Expand Down
Loading