Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): support scoping for consumer groups #756

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Sep 5, 2023

Summary

This PR enables entities-plugins to:

  • display Consumer Group in the plugin list if a plugin is scoped to a consumer group

image

  • show Consumer Group ID in the plugin config card if the plugin is scoped to a consumer group

image

Also updates FieldAutoSuggest so that the plugin form can handle consumer group selection correctly. Note that consumer group selection needs to be handled in the host app.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@Leopoldthecoder Leopoldthecoder force-pushed the feat/consumer-group-plugins branch from e8fd72f to f13ac5a Compare September 5, 2023 07:48
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review September 5, 2023 08:15
@Leopoldthecoder Leopoldthecoder force-pushed the feat/consumer-group-plugins branch from f13ac5a to 277aaae Compare September 6, 2023 03:04
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 7ec6b56 into main Sep 6, 2023
26 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/consumer-group-plugins branch September 6, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants