-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(about-section): new component [khcp-8589] #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/core/app-layout/src/components/aboutSection/AppAboutSection.vue
Outdated
Show resolved
Hide resolved
packages/core/app-layout/src/components/aboutSection/AppAboutSection.vue
Outdated
Show resolved
Hide resolved
packages/core/app-layout/src/components/aboutSection/AppAboutSection.vue
Outdated
Show resolved
Hide resolved
packages/core/app-layout/src/components/aboutSection/AppAboutSection.vue
Outdated
Show resolved
Hide resolved
createdLabel: { | ||
type: String, | ||
default: '', | ||
}, | ||
modified: { | ||
type: String, | ||
default: '', | ||
}, | ||
modifiedLabel: { | ||
type: String, | ||
default: '', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why would the createdLabel
or modifiedLabel
ever be different text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For User/Developer pages we are going to display Joined
instead of Created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's the case, should the prop names for created/modified
be more generic?
e.g. createdLabel: 'Joined'
seems a bit confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a suggestion, it maps to created_at
/updated_at
fields most of the time.
packages/core/app-layout/src/components/aboutSection/AppAboutSection.vue
Outdated
Show resolved
Hide resolved
I’m worried a bit about the amount of content being displayed at the bottom of the component. Is this accounted for in the responsive style rules? Obviously mobile is going to be a stretch, but even smaller laptop screens are going to have to wrap/stack some of this content. Could you update the sandbox to see what this looks like and then we can inspect on smaller screens? |
Co-authored-by: Adam DeHaven <[email protected]>
Summary
New
AppAboutSection
component for KHCP-8589.Also minor fixes for
TopNTable
:KCard
stylesisLoading
propFigma: https://www.figma.com/file/8UBIeLOY3YX3oF0RtDdwau/About-Section?type=design&node-id=55%3A9902&mode=dev
PR Checklist