Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics-utilities): Add date formatting support [MA-1969] #785

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

adorack
Copy link
Contributor

@adorack adorack commented Sep 13, 2023

  • Refactor tests to allow using runUtcTest in more files.
  • Add analytics-specific date format to analytics-utilities.

Summary

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

- Refactor tests to allow using `runUtcTest` in more files.
- Add analytics-specific date format to analytics-utilities.
@adorack adorack requested a review from a team as a code owner September 13, 2023 18:00
@adorack adorack merged commit 31578b4 into main Sep 14, 2023
6 checks passed
@adorack adorack deleted the chore/request-formatting branch September 14, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants