-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics-chart): better legend label truncation [MA-2048] #789
Merged
filipgutica
merged 4 commits into
main
from
fix/analytics-chart-legend-item-truncation-too-aggressive
Sep 15, 2023
Merged
fix(analytics-chart): better legend label truncation [MA-2048] #789
filipgutica
merged 4 commits into
main
from
fix/analytics-chart-legend-item-truncation-too-aggressive
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgutica
force-pushed
the
fix/analytics-chart-legend-item-truncation-too-aggressive
branch
from
September 14, 2023 20:22
93bd08e
to
50c3587
Compare
adorack
previously requested changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/analytics/analytics-chart/src/components/chart-plugins/ChartLegend.vue
Outdated
Show resolved
Hide resolved
filipgutica
force-pushed
the
fix/analytics-chart-legend-item-truncation-too-aggressive
branch
from
September 15, 2023 02:34
46581a5
to
cd8a88b
Compare
calculate the number of row in the grid layout, representing the legend by comparing the "top" position of each item incrementing the numberOfRows each time there is a difference. Use the number of rows to determine if a label should be truncated or not
filipgutica
force-pushed
the
fix/analytics-chart-legend-item-truncation-too-aggressive
branch
from
September 15, 2023 03:20
cd8a88b
to
1b4914b
Compare
mihai-peteu
previously approved these changes
Sep 15, 2023
filipgutica
force-pushed
the
fix/analytics-chart-legend-item-truncation-too-aggressive
branch
from
September 15, 2023 16:33
36a7385
to
b77e90f
Compare
mihai-peteu
approved these changes
Sep 15, 2023
filipgutica
dismissed
adorack’s stale review
September 15, 2023 22:29
Addressed your comments. Since you're on PTO, got approval from @mihai-peteu
filipgutica
deleted the
fix/analytics-chart-legend-item-truncation-too-aggressive
branch
September 15, 2023 22:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://konghq.atlassian.net/browse/MA-2048
Summary
Only truncate the label when the legend grows such that it begins to wrap to multiple rows.
calculate the number of row in the grid layout, representing
the legend by comparing the "top" position of each item
incrementing the numberOfRows each time there is a difference.
Use the number of rows to determine if a label should be
truncated or not.
Truncate when list grows and wraps to a new row.
https://www.loom.com/share/c338d6643f9d4f46baf49de6245e468a
Truncate on window resize if legend is forced into a new row.
https://www.loom.com/share/bf2b6c0d7a03428ea290f3059fe6d01d
PR Checklist