Skip to content

Commit

Permalink
issue #536 UnirestInstance should implement AutoCloseabl
Browse files Browse the repository at this point in the history
  • Loading branch information
ryber committed Nov 1, 2024
1 parent 197f2fe commit 6047748
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
3 changes: 2 additions & 1 deletion unirest/src/main/java/kong/unirest/core/UnirestInstance.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* and its clients where all the action happens.
* This class is suitable for mocking.
*/
public class UnirestInstance {
public class UnirestInstance implements AutoCloseable {

private final Config config;

Expand Down Expand Up @@ -148,6 +148,7 @@ public HttpRequestWithBody request(String method, String url) {
* used with try-with-resource. This will alleviate the need to manually
* call shutDown as it will be done automatically.
*/
@Override
public void close() {
reset(true);
}
Expand Down
43 changes: 43 additions & 0 deletions unirest/src/test/java/kong/unirest/core/UnirestInstanceTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/**
* The MIT License
*
* Copyright for portions of unirest-java are held by Kong Inc (c) 2013.
*
* Permission is hereby granted, free of charge, to any person obtaining
* a copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, sublicense, and/or sell copies of the Software, and to
* permit persons to whom the Software is furnished to do so, subject to
* the following conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
* LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
* OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/

package kong.unirest.core;

import org.junit.jupiter.api.Test;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;

class UnirestInstanceTest {

@Test
void canBeUsedWithTryWithResource() {
var mock = mock(UnirestInstance.class);

try(UnirestInstance instance = mock){ }

verify(mock).close();
}
}

0 comments on commit 6047748

Please sign in to comment.