-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2주차 미션 / 서버 2조 이준영 #45
Open
lee-june-young
wants to merge
17
commits into
Konkuk-KUIT:main
Choose a base branch
from
lee-june-young:refactor/lee-june-young
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2주차 미션 / 서버 2조 이준영 #45
lee-june-young
wants to merge
17
commits into
Konkuk-KUIT:main
from
lee-june-young:refactor/lee-june-young
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-june-young
commented
Sep 24, 2023
- 2주차 실습 영상 기반으로 리팩토링 진행
- 요구사항 2 구현:
- 요구사항 3 구현:
- 3번: 모든 원시 값과 문자열을 포장한다. (rows) - 5번: 일급 컬렉션을 사용한다. (row) - 1번: 한 메서드에 오직 한단계의 들여쓰기만 한다.(범위 체크를 메서드로 빼주었다.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.