Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more selector types #200

Merged
merged 10 commits into from
Sep 17, 2023
Merged

feat: more selector types #200

merged 10 commits into from
Sep 17, 2023

Conversation

DeDiamondPro
Copy link
Contributor

Adds support for user, role and channel selector types.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2022

Hello, and thanks for opening a pull request! As this is your first pull request to this repository we'd just like to offer you a warm welcome to the project, and the following pointers:

  • Most importantly, all contributions must adhere to our Code of Conduct and contributor guidelines. Please give them a quick read if you haven't already.
  • While our team is passionate about the projects we've created here, we're all volunteers. Please don't be offended if it takes time for us to get to your pull request - we'll be here as soon as we can be!
  • If your pull request is a work-in-progress, then please mark it as a draft (if you haven't already done so). This helps us to prioritise our review process.
  • Our review process may feel a little daunting to a newcomer. Don't worry, everyone starts somewhere! In order to make things easier, please ensure that you're linting your code. You can find more information on how to do this in the README for this project.
    Thanks again for your work so far! If you have any questions, please feel free to join us on Discord in the #dev-kotdis channel or to contact a staff member directly.

@DeDiamondPro DeDiamondPro marked this pull request as draft January 5, 2023 12:38
@DeDiamondPro DeDiamondPro marked this pull request as ready for review January 5, 2023 14:33
@gdude2002 gdude2002 changed the base branch from develop to root March 25, 2023 17:03
@gdude2002
Copy link
Member

Apologies for taking so long to get to this - would you mind checking out that conflict? I should be able to get this merged pretty soon.

@DeDiamondPro
Copy link
Contributor Author

Apologies for taking so long to get to this - would you mind checking out that conflict? I should be able to get this merged pretty soon.

I'll fix the conflict when I have time tomorrow.

@DeDiamondPro
Merge remote-tracking branch 'upstream/root' into develop
3522a66 
# Conflicts:
#	kord-extensions/src/main/kotlin/com/kotlindiscord/kord/extensions/components/menus/SelectMenu.kt
@DeDiamondPro
merge changes
90683d5
gdude2002
gdude2002 requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is pretty good - just a few things to address. Good work!

kord-extensions/src/main/kotlin/com/kotlindiscord/kord/extensions/components/_Functions.kt Show resolved Hide resolved
...ns/src/main/kotlin/com/kotlindiscord/kord/extensions/components/menus/EphemeralSelectMenu.kt Outdated Show resolved Hide resolved
...ns/src/main/kotlin/com/kotlindiscord/kord/extensions/components/menus/EphemeralSelectMenu.kt Show resolved Hide resolved
...sions/src/main/kotlin/com/kotlindiscord/kord/extensions/components/menus/PublicSelectMenu.kt Outdated Show resolved Hide resolved
...sions/src/main/kotlin/com/kotlindiscord/kord/extensions/components/menus/PublicSelectMenu.kt Show resolved Hide resolved
...rc/main/kotlin/com/kotlindiscord/kord/extensions/components/menus/string/StringSelectMenu.kt Show resolved Hide resolved
...rc/main/kotlin/com/kotlindiscord/kord/extensions/testbot/extensions/SelectorTestExtension.kt Show resolved Hide resolved
...rc/main/kotlin/com/kotlindiscord/kord/extensions/testbot/extensions/SelectorTestExtension.kt Outdated Show resolved Hide resolved
...rc/main/kotlin/com/kotlindiscord/kord/extensions/testbot/extensions/SelectorTestExtension.kt Show resolved Hide resolved
@DeDiamondPro DeDiamondPro requested a review from gdude2002 April 1, 2023 20:48
gdude2002
gdude2002 previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good - thanks for being patient. I think we can merge this once you've merged in the latest changes and verified it all works.

@gdude2002
Copy link
Member

Looks good, thanks for your work!

@gdude2002 gdude2002 merged commit 32e3882 into Kord-Extensions:root Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdude2002 gdude2002 Awaiting requested review from gdude2002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeDiamondPro @gdude2002