Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mappings extension to storage unit #201

Merged
merged 12 commits into from
Nov 11, 2023

Conversation

NoComment1105
Copy link
Contributor

Re-done this time. Should be fully functioning.

@gdude2002 gdude2002 changed the base branch from develop to root March 25, 2023 17:03
@gdude2002
Copy link
Member

I'm unsure what specifically to do with this one.

The mappings extension is useful for sure, but it's been impossible for me to maintain it for a long time, and @sschr15 seems like he's too busy to do much with it these days.

Additionally, the storage unit system needs a major rework at some point, something which I'm very unlikely to be able to do any time soon.

There is a conflict to resolve here, but I'm left feeling like I didn't give you the right brief to solve this properly - but I don't have the spoons to do a proper review right now anyway, so I'm not sure.

@NoComment1105
Copy link
Contributor Author

Hm, Ok then. I'll resolve the conflict, then let me know when you have appropriate spoons

Copy link
Contributor

@sschr15 sschr15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Fantastic that I didn't realize I had been mentioned for a bit of code I've done things with

@gdude2002
Copy link
Member

It's unfortunate that this has gone so long until you managed to get a review in - but when the merge conflicts are solved, things are re-tested, and you're happy with it, we can probably merge @sschr15

@NoComment1105 NoComment1105 requested a review from sschr15 October 6, 2023 08:48
@NoComment1105
Copy link
Contributor Author

@gdude2002 Could this have a final review please? sschr15 has approved it

gdude2002
gdude2002 previously approved these changes Oct 27, 2023
Copy link
Member

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find much to criticise here - but as always, I need confirmation that these changes were tested.

@sschr15
Copy link
Contributor

sschr15 commented Oct 28, 2023

Unless the merge commit broke something, I did testing before sending over the patch that was implemented

gdude2002
gdude2002 previously approved these changes Oct 30, 2023
@gdude2002
Copy link
Member

Alright, well then I'll merge it when you've got it to pass the linter.

image

@gdude2002
Copy link
Member

That was an odd one, wasn't it?

Anyway, thanks, I think we finally made it!

@gdude2002 gdude2002 merged commit ab1b48b into Kord-Extensions:root Nov 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants