-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change extension name sentry context to a mapping #295
Change extension name sentry context to a mapping #295
Conversation
Sorry, I've been pretty busy.
|
Alright, so I'm working in those changes now. One question, I see that for chat commands we have In my opinion, I think it would be a good idea to use I haven't used chat commands, so I'm not sure what |
- Also add group and parent commands to Slash commands
We should use the |
This is ready for review. Only thing missing would be chat command parents, but I'm not familiar with chat commands. But To be honest I would lean towards doing the same in Slash commands, have name be the full command text, so it matches chat commands. If that would be preferred, I can make that change, otherwise, this is ready. |
I think splitting them out should aid with more complex filtering. That said, I'm unsure about the inconsistency there - though then again, I suppose combining them would more easily allow partial matches? Ah, screw it, let's combine them. I'll merge after that. |
Merged them. Example name key with test commands:
Which corresponds to this: publicSlashCommand {
name = "command.banana-group"
description = "Translated banana group"
group("command.banana") {
description = "Translated banana group"
publicSubCommand {
name = "command.banana"
description = "Translated banana" |
Looks good, thanks! |
We discussed this briefly on Discord: https://canary.discord.com/channels/1121419906995458098/1210756178515206164
But basically, Sentry is expecting an object, not a single value, so it shows this warning:
This is ready as it is, but this change made me think of further possible changes:
extension.name
be merged intocommand
ascommand.extension
?./respawn-manage bump-user
). So I'm thinking of doing either of these:name
as is, addparent
if it is a subcommand and put the parent's name there.name
always be the root command, and addsubcommand
if it is a subcommand? Probably a good idea to also havegroup
in here.I think having just the name would be ambiguous as it is common to have a pattern like:
/guild edit
,/member edit
,/channel edit
, so they would all be listed as "edit".