Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception when running with KSP2 #301

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

DRSchlaubi
Copy link
Contributor

@DRSchlaubi DRSchlaubi commented Jun 3, 2024

Seemingly Enum constants are now KSClassDeclarations rather than KSTypes

@gdude2002
Copy link
Member

The branch you've targeted does not support K2 - did you mean to target the K2 branch?

@DRSchlaubi
Copy link
Contributor Author

The branch you've targeted does not support K2 - did you mean to target the K2 branch?

I specifically said KSP2 not K2, the project seems to work fine on KSP2 when not using k2

@gdude2002
Copy link
Member

Is there a reason to rush the usage of KSP 2 before we can even use K2?

@DRSchlaubi
Copy link
Contributor Author

Is there a reason to rush the usage of KSP 2 before we can even use K2?

I want to upgrade my project to KSP2 and this prevents me from doing so haha

Also it doesn't seem to cause issues with k1 users, so why not upgrade to KSP2 while we can, seems to have no downside

@gdude2002
Copy link
Member

Did you test the converter system via the test bot?

@DRSchlaubi
Copy link
Contributor Author

Did you test the converter system via the test bot?

I did not, I assumed if KSP would cause issues they would be compile-time issues, not runtime issues

Copy link
Member

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after test confirmation on Discord.

@gdude2002 gdude2002 merged commit a3590f1 into Kord-Extensions:root Jun 4, 2024
3 checks passed
@gdude2002
Copy link
Member

Thanks!

@DRSchlaubi DRSchlaubi deleted the feature/ksp2 branch June 4, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants