Fix invalid order of sprintf arguments in CurrencyExchangeRates - issue

#1
Kreyu · Jun 8, 2021 · 0ef092c · 0ef092c
1 parent 30c3649
commit 0ef092c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -23,6 +23,8 @@
     "webmozart/assert": "^1.0"
   },
   "require-dev": {
+    "ext-dom": "*",
+    "ext-mbstring": "*",
     "guzzlehttp/psr7": "^1.2",
     "http-interop/http-factory-guzzle": "^1.0",
     "phpunit/phpunit": "^8.2.3",

diff --git a/src/Api/CurrencyExchangeRates.php b/src/Api/CurrencyExchangeRates.php
@@ -38,7 +38,7 @@ public function __construct(ClientInterface $client, string $tableType, string $
         Assert::notEmpty($currencyCode);
         Assert::maxLength($currencyCode, 3);
 
-        $this->currencyCode = $currencyCode;
+        $this->currencyCode = strtolower($currencyCode);
     }
 
     /**
@@ -49,7 +49,7 @@ public function __construct(ClientInterface $client, string $tableType, string $
      */
     public function all(): ResponseInterface
     {
-        return $this->get(sprintf('exchangerates/rates/%s/%s', $this->currencyCode, $this->tableType));
+        return $this->get(sprintf('exchangerates/rates/%s/%s', $this->tableType, $this->currencyCode));
     }
 
     /**
@@ -62,7 +62,7 @@ public function all(): ResponseInterface
      */
     public function latest(int $count): ResponseInterface
     {
-        return $this->get(sprintf('exchangerates/rates/%s/%s/last/%d', $this->currencyCode, $this->tableType, $count));
+        return $this->get(sprintf('exchangerates/rates/%s/%s/last/%d', $this->tableType, $this->currencyCode, $count));
     }
 
     /**
@@ -74,7 +74,7 @@ public function latest(int $count): ResponseInterface
      */
     public function today(): ResponseInterface
     {
-        return $this->get(sprintf('exchangerates/rates/%s/%s/today', $this->currencyCode, $this->tableType));
+        return $this->get(sprintf('exchangerates/rates/%s/%s/today', $this->tableType, $this->currencyCode));
     }
 
     /**
@@ -90,8 +90,8 @@ public function inDate(DateTimeInterface $date): ResponseInterface
     {
         return $this->get(sprintf(
             'exchangerates/rates/%s/%s/%s',
-            $this->currencyCode,
             $this->tableType,
+            $this->currencyCode,
             $date->format(self::DATE_FORMAT)
         ));
     }
@@ -110,10 +110,10 @@ public function betweenDates(DateTimeInterface $startDate, DateTimeInterface $en
     {
         return $this->get(sprintf(
             'exchangerates/rates/%s/%s/%s/%s',
-            $this->currencyCode,
             $this->tableType,
+            $this->currencyCode,
             $startDate->format(self::DATE_FORMAT),
             $endDate->format(self::DATE_FORMAT)
         ));
     }
-}
+}