Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #162.
It looks like adding the information to the CSV template sorts out the issue of missing names/descriptions.
There is one peculiar thing caused by two versions of AuthConfig CRD which results in two seemingly duplicated cards rendered in OperatorHub.
While the displayed name could be altered so the first card would display for example
AuthConfig/v1beta1
and the second cardAuthConfig/v1beta2
the YAML example displayed on both cards would still show an example fromAuthConfig/v1beta2
(even for v1beta1 card), despite examples existing for both versions in the CSV file. It's a bit confusing, I hope this describes the issue in an understandable way.For this reason I have included the example YAML for
AuthConfig/v1beta2
only and kept thedisplayName
for both versions asAuthConfig
. This way the OperatorHub will only show the most recent version to the visitors with a correct YAML example.As an example, this approach can be also seen in ArgoCD operator with the
Argo CD
schema.To verify the changes, copy the full contents of the generated CSV manifest to OperatorHub Preview tool.
Also a pic of how it looks like after the changes: