Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning docker builds #174

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Aligning docker builds #174

merged 1 commit into from
Nov 29, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Nov 29, 2024 •
edited
Loading

Resolves #175 - see that issue for more details.

@jasonmadigan
Aligning docker builds
863eb02 
Signed-off-by: Jason Madigan <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member Author

@jjkiely - was able to reproduce. will submit a PR downstream to do similar

@jasonmadigan
Copy link
Member Author

Will cherry-pick to kuadrant-v1.0.0 after merge.

@jasonmadigan jasonmadigan merged commit 5918a8d into Kuadrant:main Nov 29, 2024
5 of 7 checks passed
@jasonmadigan
Copy link
Member Author

/cherry-pick kuadrant-v1.0.0

@openshift-cherrypick-robot
Copy link

@jasonmadigan: new pull request created: #176

In response to this:

/cherry-pick kuadrant-v1.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 29, 2024
Merged
@jasonmadigan jasonmadigan deleted the align-docker-builds branch December 2, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-martin david-martin Awaiting requested review from david-martin

@R-Lawton R-Lawton Awaiting requested review from R-Lawton

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UBI image issues with nginx permissions
2 participants
@jasonmadigan @openshift-cherrypick-robot