Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override fonts from component #86

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Sep 30, 2024

Re: #82

Signed-off-by: Jason Madigan <[email protected]>
@jasonmadigan
Copy link
Member Author

Previous first load:

Screenshot 2024-09-30 at 09 42 19

Now:

Screenshot 2024-09-30 at 11 23 39

bug: some fonts overridden at a component level.

@david-martin
Copy link
Member

/lgtm
/approve

I observed this recently and thought it might be a screen size thing. Thanks for fixing

Copy link

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b66c8c5 into main Oct 1, 2024
3 checks passed
@jasonmadigan jasonmadigan deleted the 82-topology-fonts branch October 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

On first load, the policy topology page doesn't render with the right fonts
2 participants